Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to use of ES Modules #667

Merged
merged 12 commits into from
Jun 25, 2024
Merged

Migrate to use of ES Modules #667

merged 12 commits into from
Jun 25, 2024

Conversation

chadlwilson
Copy link
Contributor

@chadlwilson chadlwilson commented Jun 20, 2024

  • Moves minimum node version to v18 (latest LTS at time of PR)
  • Changes gauge-js to an ES module, removing all use of CommonJS requires
  • Prefers use of node: prefixed imports
  • Upgrades and de-duplicates dependencies to latest

@chadlwilson

This comment was marked as resolved.

@chadlwilson chadlwilson linked an issue Jun 20, 2024 that may be closed by this pull request
chadlwilson and others added 7 commits June 21, 2024 10:48
Signed-off-by: Chad Wilson <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@chadlwilson chadlwilson force-pushed the experimental-es-modules branch from 25c8b2c to 4dfe346 Compare June 21, 2024 02:49
@chadlwilson

This comment was marked as resolved.

This is the oldest LTS version still maintained/security-patched in June 2024.

Signed-off-by: Chad Wilson <[email protected]>
@chadlwilson chadlwilson force-pushed the experimental-es-modules branch from d877775 to d0a625f Compare June 21, 2024 03:11
eslint.config.js Outdated Show resolved Hide resolved
scripts/install.js Outdated Show resolved Hide resolved
src/message-processor.js Outdated Show resolved Hide resolved
Ensures it matches earlier semantics with use of `require`

Signed-off-by: Chad Wilson <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil zabil marked this pull request as ready for review June 24, 2024 15:19
@chadlwilson chadlwilson added the ReleaseCandidate If a PR is tagged with this label, after merging it will be released label Jun 25, 2024
@gaugebot
Copy link

gaugebot bot commented Jun 25, 2024

@chadlwilson Thank you for contributing to gauge-js. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@zabil zabil merged commit 2237e9f into master Jun 25, 2024
8 checks passed
@chadlwilson chadlwilson deleted the experimental-es-modules branch June 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseCandidate If a PR is tagged with this label, after merging it will be released technical
Development

Successfully merging this pull request may close these issues.

Migrate gauge-js to be an es module
2 participants