Bump chai from 4.4.1 to 5.1.1 #655

dependabot · 2024-05-13T02:33:44Z

Bumps chai from 4.4.1 to 5.1.1.

Release notes

v5.1.1

What's Changed

Set up ESLint for JSDoc comments by @koddsson in chaijs/chai#1605

build(deps-dev): bump ip from 1.1.8 to 1.1.9 by @dependabot in chaijs/chai#1608

Correct Mocha import instructions by @MattiSG in chaijs/chai#1611

fix: support some virtual contexts in toThrow by @43081j in chaijs/chai#1609

New Contributors

@MattiSG made their first contribution in chaijs/chai#1611

Full Changelog: chaijs/chai@v5.1.0...v5.1.1

v5.1.0

What's Changed

Remove useless guards and add parentheses to constuctors by @koddsson in chaijs/chai#1593

Cleanup jsdoc comments by @koddsson in chaijs/chai#1596

Convert comments in "legal comments" format to jsdoc or normal comments by @koddsson in chaijs/chai#1598

Implement iterable assertion by @koddsson in chaijs/chai#1592

Assert interface fix by @developer-bandi in chaijs/chai#1601

Set support in same members by @koddsson in chaijs/chai#1583

Fix publish script by @koddsson in chaijs/chai#1602

New Contributors

@developer-bandi made their first contribution in chaijs/chai#1601

Full Changelog: chaijs/chai@v5.0.3...v5.1.0

v5.0.3

Fix bad v5.0.2 publish.

Full Changelog: chaijs/chai@v5.0.2...v5.0.3

v5.0.2

What's Changed

build(deps): bump nanoid and mocha by @dependabot in chaijs/chai#1558

remove bump-cli by @koddsson in chaijs/chai#1559

Update developer dependencies by @koddsson in chaijs/chai#1560

fix: removes ?? for node compat (5.x) by @43081j in chaijs/chai#1576

Update loupe to latest version by @koddsson in chaijs/chai#1579

Re-enable some webkit tests by @koddsson in chaijs/chai#1580

Remove a bunch of if statements in test/should.js by @koddsson in chaijs/chai#1581

Remove a bunch of unused files by @koddsson in chaijs/chai#1582

Fix 1564 by @koddsson in chaijs/chai#1566

Full Changelog: chaijs/chai@v5.0.1...v5.0.2

v5.0.0

BREAKING CHANGES

Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have import {...} from 'chai' or import('chai'). require('chai') will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls.

... (truncated)

Commits

37263c0 fix: support some virtual contexts in toThrow (#1609)
91e58ed Correct Mocha import instructions (#1611)
61159d1 build(deps-dev): bump ip from 1.1.8 to 1.1.9 (#1608)
8475d2a Set up ESLint for JSDoc comments (#1605)
936c0ca 5.1.0
2cf92f5 Fix publish script (#1602)
1ba37b5 Set support in same members (#1583)
f224339 Assert interface fix (#1601)
d504573 Implement iterable assertion (#1592)
640d932 Convert comments in "legal comments" format to jsdoc (#1598)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

zabil · 2024-06-14T16:37:52Z

@dependabot rebase

Bumps [chai](https://github.com/chaijs/chai) from 4.4.1 to 5.1.1. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/main/History.md) - [Commits](chaijs/chai@v4.4.1...v5.1.1) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

zabil · 2024-06-20T14:22:49Z

This is stuck because the latest version of chai switched to ES modules, and now I'm getting an error.

Exception during run: Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/zabilcm/projects/gauge-js/node_modules/chai/chai.js from /Users/zabilcm/projects/gauge-js/test/custom-message-registry-test.js not supported.
Instead change the require of chai.js in /Users/zabilcm/projects/gauge-js/test/custom-message-registry-test.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/Users/zabilcm/projects/gauge-js/test/custom-message-registry-test.js:1:14)
    at async formattedImport (/Users/zabilcm/projects/gauge-js/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async exports.requireOrImport (/Users/zabilcm/projects/gauge-js/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async exports.loadFilesAsync (/Users/zabilcm/projects/gauge-js/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/Users/zabilcm/projects/gauge-js/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async exports.handler (/Users/zabilcm/projects/gauge-js/node_modules/mocha/lib/cli/run.js:370:5) {
  code: 'ERR_REQUIRE_ESM'

The best way to handle this, since other dependencies might do the same, is to change gauge js to an ES module and increase the major version number. This will make sure the dependencies can be updated without getting stuck.

What do you think?

zabil · 2024-06-20T14:23:25Z

Also being discussed on hacker news today

https://borischerny.com/javascript,/typescript/2024/06/19/ES-Modules-Are-A-Mess.html

chadlwilson · 2024-06-20T14:58:48Z

Yeah, this has been an ongoing debate for years now, and almost a joke at this point when trying to wade through babel, webpack, typescript, corejs configurations etc and make all this stuff actually work (if you have any older versions of anything).

I'm not sure I have a sufficiently well educated opinion yet on what should happen for gauge-js itself but definitely seems like moving to an ES module make sense and probably has limited risk given the way gauge-js is used? (likely with Node only, on dev machines, as a top level dependency in a package.json)

Given I moved Node 16 to minimum back in Jan we should be relatively clean to move anyway.

zabil · 2024-06-20T15:18:57Z

Yeah I think the risk is limited. I'd like investigate this and hopefully send a PR. Will create an issue to track this.

chadlwilson · 2024-06-20T16:05:10Z

Thought it might be easy, but seems at least not trivial - experiment at #667

chadlwilson · 2024-06-20T16:05:27Z

Feel free to butcher that branch at will :-)

zabil · 2024-06-20T17:08:50Z

I think it's because of this line

 ].concat(module.paths.filter((p) => p.indexOf(".gauge") < 0));

module.exports module.paths no longer available in es modules.

chadlwilson · 2024-06-20T17:15:00Z

Yup, it is - that's just as far as I got up to before trying to figure out what that is doing and the consequences for those using the plugin, and thus gave up for now :-)

chadlwilson · 2024-06-21T03:13:35Z

We'll do this within #667 since it's coupled.

dependabot · 2024-06-21T03:13:37Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 13, 2024

dependabot bot mentioned this pull request May 13, 2024

Bump chai from 4.4.1 to 5.1.0 #632

Closed

chadlwilson marked this pull request as draft May 13, 2024 03:10

dependabot bot force-pushed the dependabot/npm_and_yarn/chai-5.1.1 branch from 129b7ce to d142ce7 Compare June 14, 2024 16:38

zabil mentioned this pull request Jun 20, 2024

Migrate gauge-js to be an es module #666

Closed

chadlwilson closed this Jun 21, 2024

dependabot bot deleted the dependabot/npm_and_yarn/chai-5.1.1 branch June 21, 2024 03:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump chai from 4.4.1 to 5.1.1 #655

Bump chai from 4.4.1 to 5.1.1 #655

dependabot bot commented on behalf of github May 13, 2024 •

edited

Loading

zabil commented Jun 14, 2024

zabil commented Jun 20, 2024

zabil commented Jun 20, 2024

chadlwilson commented Jun 20, 2024

zabil commented Jun 20, 2024

chadlwilson commented Jun 20, 2024

chadlwilson commented Jun 20, 2024 •

edited

Loading

zabil commented Jun 20, 2024

chadlwilson commented Jun 20, 2024

chadlwilson commented Jun 21, 2024

dependabot bot commented on behalf of github Jun 21, 2024

Bump chai from 4.4.1 to 5.1.1 #655

Bump chai from 4.4.1 to 5.1.1 #655

Conversation

dependabot bot commented on behalf of github May 13, 2024 • edited Loading

v5.1.1

What's Changed

New Contributors

v5.1.0

What's Changed

New Contributors

v5.0.3

v5.0.2

What's Changed

v5.0.0

BREAKING CHANGES

zabil commented Jun 14, 2024

zabil commented Jun 20, 2024

zabil commented Jun 20, 2024

chadlwilson commented Jun 20, 2024

zabil commented Jun 20, 2024

chadlwilson commented Jun 20, 2024

chadlwilson commented Jun 20, 2024 • edited Loading

zabil commented Jun 20, 2024

chadlwilson commented Jun 20, 2024

chadlwilson commented Jun 21, 2024

dependabot bot commented on behalf of github Jun 21, 2024

dependabot bot commented on behalf of github May 13, 2024 •

edited

Loading

chadlwilson commented Jun 20, 2024 •

edited

Loading