BGDIINF_SB-3115: Fixed IOS 16.6 403 Forbidden #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently IOS 16.6.1 (some other previous version might also be concerd) has a bug and set Sec-Fetch-Site=cross-site even if the request is originated (same origin and/or referrer) from the same site ! Therefore to avoid issue on IOS we first checks the referrer before checking Sec-Fetch-Site even if this not correct/safe (Referrer header is easily hacked, while Sec-Fetch-Site is always overwritten by the browser). Also clean up makefile, differentiating between `make dev` and `make setup` doesn't make sense as we never install locally without the dev dependencies and nowadays most of our services only have `make setup` with dev dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently IOS 16.6.1 (some other previous version might also be concerd) has
a bug and set Sec-Fetch-Site=cross-site even if the request is originated
(same origin and/or referrer) from the same site ! Therefore to avoid issue on
IOS we first checks the referrer before checking Sec-Fetch-Site even if this not
correct/safe (Referrer header is easily hacked, while Sec-Fetch-Site is always
overwritten by the browser).
Also clean up makefile, differentiating between
make devandmake setupdoesn't make sense as we never install locally without the dev dependencies and
nowadays most of our services only have
make setupwith dev dependencies.