PB-934: Removed origin check #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow request if no origin/referer is set. If an origin is set, then returns correct CORS headers.
boecklic
approved these changes
Aug 29, 2024
Comment on lines
+47
to
+48
| if 'Referer' in request.headers and is_domain_allowed(request.headers['Referer']): | ||
| cors_origin = request.headers['Referer'] |
There was a problem hiding this comment.
so Referer wins over Origin? Why not just check for Origin?
There was a problem hiding this comment.
Because some browser like IOS, see #59, don't set origin but referer. So we need this in order to avoid CORS issue on some browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow request if no origin/referer is set. If an origin is set, then returns
correct CORS headers.