-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly screen elements inside iframes #856
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,7 +150,7 @@ Rect.prototype = { | |
|
||
exports.Rect = Rect; | ||
exports.getAbsoluteClientRect = function getAbsoluteClientRect(element, opts) { | ||
var coords = element.getBoundingClientRect(); | ||
var coords = getNestedBoundingClientRect(element, window); | ||
var widthRatio = coords.width % opts.viewportWidth; | ||
var heightRatio = coords.height % opts.documentHeight; | ||
|
||
|
@@ -164,3 +164,76 @@ exports.getAbsoluteClientRect = function getAbsoluteClientRect(element, opts) { | |
|
||
return clientRect.translate(util.getScrollLeft(opts.scrollElem), util.getScrollTop(opts.scrollElem)); | ||
}; | ||
|
||
function getNestedBoundingClientRect(node, boundaryWindow) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Found solution in this package - https://github.com/suchipi/get-nested-bounding-client-rect/tree/master. The basic logic is taken from it with some modification for our use case. |
||
var ownerIframe = util.getOwnerIframe(node); | ||
if (ownerIframe === null || util.getOwnerWindow(ownerIframe) === boundaryWindow) { | ||
return node.getBoundingClientRect(); | ||
} | ||
|
||
var rects = [node.getBoundingClientRect()]; | ||
var currentIframe = ownerIframe; | ||
|
||
while (currentIframe) { | ||
var rect = getBoundingClientRectWithBorderOffset(currentIframe); | ||
rects.push(rect); | ||
|
||
currentIframe = util.getOwnerIframe(currentIframe); | ||
if (currentIframe && util.getOwnerWindow(currentIframe) === boundaryWindow) { | ||
rect = getBoundingClientRectWithBorderOffset(currentIframe); | ||
rects.push(rect); | ||
break; | ||
} | ||
} | ||
|
||
return mergeRectOffsets(rects); | ||
} | ||
|
||
function getBoundingClientRectWithBorderOffset(node) { | ||
var dimensions = getElementDimensions(node); | ||
|
||
return mergeRectOffsets([ | ||
node.getBoundingClientRect(), | ||
{ | ||
top: dimensions.borderTop, | ||
left: dimensions.borderLeft, | ||
bottom: dimensions.borderBottom, | ||
right: dimensions.borderRight, | ||
x: dimensions.borderLeft, | ||
y: dimensions.borderTop | ||
} | ||
]); | ||
} | ||
|
||
function getElementDimensions(element) { | ||
var calculatedStyle = util.getOwnerWindow(element).getComputedStyle(element); | ||
|
||
return { | ||
borderLeft: parseFloat(calculatedStyle.borderLeftWidth), | ||
borderRight: parseFloat(calculatedStyle.borderRightWidth), | ||
borderTop: parseFloat(calculatedStyle.borderTopWidth), | ||
borderBottom: parseFloat(calculatedStyle.borderBottomWidth) | ||
}; | ||
} | ||
|
||
function mergeRectOffsets(rects) { | ||
return rects.reduce(function (previousRect, rect) { | ||
if (previousRect === null) { | ||
return rect; | ||
} | ||
|
||
var nextTop = previousRect.top + rect.top; | ||
var nextLeft = previousRect.left + rect.left; | ||
|
||
return { | ||
top: nextTop, | ||
left: nextLeft, | ||
width: previousRect.width, | ||
height: previousRect.height, | ||
bottom: nextTop + previousRect.height, | ||
right: nextLeft + previousRect.width, | ||
x: nextLeft, | ||
y: nextTop | ||
}; | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If user use command
browser.switchToFrame(<iframe>)
in test thendocument.documentElement
references to the document inside frame which has its own dimensions. It can't be used becausegetBoundingClientRect
inside iframe returns rect only inside this iframe.So I should use main document in order to correctly screen element inside iframe.