fix: correctly screen elements inside iframes #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
force-pushed
the
HERMIONE-636.fix_assert_elements_in_iframe
branch
from
17d0095 to
15e8488
Compare
DudaGod
commented
Mar 6, 2024
| viewportHeight = document.documentElement.clientHeight, | ||
| documentWidth = document.documentElement.scrollWidth, | ||
| documentHeight = document.documentElement.scrollHeight, | ||
| var mainDocumentElem = util.getMainDocumentElem(), |
There was a problem hiding this comment.
If user use command browser.switchToFrame(<iframe>) in test then document.documentElement references to the document inside frame which has its own dimensions. It can't be used because getBoundingClientRect inside iframe returns rect only inside this iframe.
So I should use main document in order to correctly screen element inside iframe.
| @@ -164,3 +164,76 @@ exports.getAbsoluteClientRect = function getAbsoluteClientRect(element, opts) { | |||
|
|
|||
| return clientRect.translate(util.getScrollLeft(opts.scrollElem), util.getScrollTop(opts.scrollElem)); | |||
| }; | |||
|
|
|||
| function getNestedBoundingClientRect(node, boundaryWindow) { | |||
There was a problem hiding this comment.
Found solution in this package - https://github.com/suchipi/get-nested-bounding-client-rect/tree/master. The basic logic is taken from it with some modification for our use case.
DudaGod
force-pushed
the
HERMIONE-636.fix_assert_elements_in_iframe
branch
from
ce77d15 to
16bc710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
getBoundingClientRectinside iframe returns DOMRect only inside this iframe and don't know nothing about offsets between this iframe and viewport. Therefore, a solution has been implemented that takes into account the indentation of the iframeFix issue - #349