Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-write main parts of GUI mode to typescript #518

Merged
merged 12 commits into from
Nov 7, 2023

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Oct 30, 2023

What's done?

  • Re-wrote major parts of GUI mode to typescript, including tree-builder, report-builder, constants, runner, etc.
  • Tried to keep logic mostly unchanged, while only adding type annotations
  • Got rid of some unnecessary fields (origAttempt, decreaseAttemptNumber, etc)
  • Fixed all unit tests

You may want to some of the largest files in a per-commit view, because in a regular view they show up as added from scratch.

Tests are failing because I haven't uploaded package-json in order to keep PR diff real. Will upload it later.

@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1004.typescript-1 branch from ba4c54e to eb23b28 Compare November 1, 2023 21:35
lib/common-utils.ts Show resolved Hide resolved
lib/constants/database.ts Show resolved Hide resolved
lib/constants/database.ts Outdated Show resolved Hide resolved
lib/db-utils/common.ts Outdated Show resolved Hide resolved
lib/gui/constants/client-events.ts Show resolved Hide resolved
lib/report-builder/gui.ts Show resolved Hide resolved
lib/tests-tree-builder/gui.ts Show resolved Hide resolved
lib/constants/database.ts Outdated Show resolved Hide resolved
lib/report-builder/gui.ts Outdated Show resolved Hide resolved
lib/report-builder/gui.ts Show resolved Hide resolved
lib/tests-tree-builder/gui.ts Show resolved Hide resolved
lib/tests-tree-builder/gui.ts Outdated Show resolved Hide resolved
lib/report-builder/gui.ts Show resolved Hide resolved
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1004.typescript-1 branch from eb23b28 to 3c2d78c Compare November 7, 2023 12:28
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1004.typescript-1 branch from 3c2d78c to 6d7eefe Compare November 7, 2023 12:58
@shadowusr shadowusr merged commit 637b71b into master Nov 7, 2023
5 checks passed
@shadowusr shadowusr deleted the users/shadowusr/HERMIONE-1004.typescript-1 branch November 8, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants