fix: minor bug fixes

gemini-testing · Nov 7, 2023 · 3c2d78c · 3c2d78c
1 parent 245de9a
commit 3c2d78c
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/.babelignore b/.babelignore
diff --git a/.babelrc → babel.config.json b/.babelrc → babel.config.json
diff --git a/lib/gui/tool-runner/index.js b/lib/gui/tool-runner/index.js
@@ -150,7 +150,7 @@ module.exports = class ToolRunner {
                 }
 
                 if (shouldRevertReference) {
-                    await reporterHelper.revertReferenceImage(formattedResult, stateName);
+                    await reporterHelper.revertReferenceImage(removedResult, formattedResult, stateName);
                 }
 
                 if (previousExpectedPath) {
@@ -250,7 +250,7 @@ module.exports = class ToolRunner {
             return _.extend(imageInfo, {expectedImg: refImg});
         });
 
-        const res = _.merge({}, rawTest, {assertViewResults, imagesInfo, sessionId, attempt, origAttempt: attempt, meta: {url}, updated: true});
+        const res = _.merge({}, rawTest, {assertViewResults, imagesInfo, sessionId, attempt, meta: {url}, updated: true});
 
         // _.merge can't fully clone test object since hermione@7+
         // TODO: use separate object to represent test results. Do not extend test object with test results

diff --git a/lib/reporter-helpers.js b/lib/reporter-helpers.js
@@ -7,7 +7,7 @@ const {getShortMD5} = require('./common-utils');
 const utils = require('./server-utils');
 const {ImageHandler} = require('./image-handler');
 
-const mkReferenceId = (testId, stateName) => getShortMD5(`${testId}#${stateName}`);
+const mkReferenceHash = (testId, stateName) => getShortMD5(`${testId}#${stateName}`);
 
 exports.updateReferenceImage = async (testResult, reportPath, stateName) => {
     const currImg = ImageHandler.getCurrImg(testResult.assertViewResults, stateName) ?? {};
@@ -19,7 +19,7 @@ exports.updateReferenceImage = async (testResult, reportPath, stateName) => {
     const referencePath = ImageHandler.getRefImg(testResult.assertViewResults, stateName)?.path;
 
     if (utils.fileExists(referencePath)) {
-        const referenceId = mkReferenceId(testResult.id, stateName);
+        const referenceId = mkReferenceHash(testResult.id, stateName);
         const oldReferencePath = path.resolve(tmp.tmpdir, referenceId);
         await utils.copyFileAsync(referencePath, oldReferencePath);
     }
@@ -30,9 +30,9 @@ exports.updateReferenceImage = async (testResult, reportPath, stateName) => {
     ]);
 };
 
-exports.revertReferenceImage = (testResult, stateName) => {
-    const referenceId = mkReferenceId(testResult.id, stateName);
-    const oldReferencePath = path.resolve(tmp.tmpdir, referenceId);
+exports.revertReferenceImage = (referenceId, testResult, stateName) => {
+    const referenceHash = mkReferenceHash(referenceId, stateName);
+    const oldReferencePath = path.resolve(tmp.tmpdir, referenceHash);
     const referencePath = ImageHandler.getRefImg(testResult.assertViewResults, stateName)?.path;
 
     return utils.copyFileAsync(oldReferencePath, referencePath);

diff --git a/lib/test-adapter/hermione.ts b/lib/test-adapter/hermione.ts
@@ -49,7 +49,7 @@ export class HermioneTestAdapter implements ReporterTestResult {
         this._testResult = testResult;
         this._testId = mkTestId(testResult.fullTitle(), testResult.browserId);
         this._errorDetails = null;
-        this._timestamp = this._testResult.timestamp;
+        this._timestamp = this._testResult.timestamp ?? this._testResult.startTime ?? Date.now();
         this._status = status;
 
         const browserVersion = _.get(this._testResult, 'meta.browserVersion', this._testResult.browserVersion);

diff --git a/test/func/fixtures/playwright/tests/failed-describe.spec.ts b/test/func/fixtures/playwright/tests/failed-describe.spec.ts
@@ -34,6 +34,7 @@ test.describe('failed describe', () => {
         test.skip(true, 'foo-bar');
     });
 
+    // Warning: this test may fail unless launched inside docker container
     test('test with successful assertView and error', async ({page, baseURL}) => {
         await page.goto(baseURL as string);