refactor(tests): Always use debug in tests
#3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecaralice
force-pushed
the
ac/fix-macos-tests
branch
from
e08ae5f to
ebf925f
Compare
Previously `cfg!(any(feature="debug", debug_assertions))` was equivalent to `cfg!(debug_assertions)`. Now test code relies on `debug` feature for panic messages.
thecaralice
force-pushed
the
ac/fix-macos-tests
branch
from
ebf925f to
019fefd
Compare
thecaralice
added
A0-pleasereview
shamilsan
approved these changes
Nov 30, 2023
shamilsan
reviewed
Nov 30, 2023
shamilsan
reviewed
Nov 30, 2023
thecaralice
changed the title
debug featuredebug in tests
StackOverflowExcept1on
approved these changes
Nov 30, 2023
clearloop
approved these changes
Dec 1, 2023
breathx
approved these changes
Dec 1, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
cfg!(any(feature="debug", debug_assertions))was equivalent tocfg!(debug_assertions), sincedebugdoes not exist, which caused tests to assert different things depending on--releaseflag.Since there is close to no reason to run a dozen different things only for panic handler to ignore any panic payload and assert that it returns
"no info", now the used-to-be-debugbehavior is the default and the only one in tests.Related: #3470