-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crates-io): publish gstd and gear-wasm-builder #3515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need publish it on each commit? that's meaningless. we must do it only on releases
the version is not bumping but with commit hash https://crates.io/crates/actor-system-error/1.0.2-354d660.8, btw since we are bumping versions before release, we can not run publishing tests with CI ( because --dry-run requires all dependencies being published ), the overall logic is easy to be broken once we add more local dependencies to the to-be-published packages |
I think we can remove it now ( Lines 501 to 504 in 3a06def
|
So please write comment about it in each to-be-published crates toml. Also here's space to write some tooling that will check it. We bump after releases so master always has greater version than last release. Also I couldn't find |
see the chat in our tg channel |
@thecaralice care to take a look? |
rust-lang/cargo#1169 has been open for eight years now and still doesn't even have a draft implementation PR, so I don't think it will be implemented anytime soon. However, the discussion mentions different solutions being: The latter looks pretty promising. Note: looks like |
What I dislike about this specific PR is that it doesn't have a single issue it addresses. I believe it should be split into several PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
these tools don't work for our situation, bcz we need to modify specified dependencies before publishing them https://github.com/gear-tech/gear/blob/cl/issue-3500/utils/crates-io/src/rename.rs
we are not using
this is part of
crates-io-manager is not in production for now since there are still some packages needed to be published but not included in its logic |
@breathx ? |
Resolves #3500
Resolves #3528
Resolves #3131
-> gear-pwasm-utils
)gstd
gear-wasm-builder
testing action: https://github.com/gear-tech/gear/actions/runs/6970605696/job/18968871282
@gear-tech/dev