Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm-instrument): move syscall table test to core-backend #3460

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Oct 30, 2023

Resolves # .

  • core-backend already has dependency gear-wasm-instrument
  • core-backend as dependency of gear-wasm-instrument makes it bigger and blocks uploading it to crates-io

blocks #3103

@gear-tech/dev

@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Oct 30, 2023
@breathx
Copy link
Member

breathx commented Nov 10, 2023

For some reason build was skipped but PR is still able to be merged? hm @clearloop

@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Nov 10, 2023
@breathx breathx changed the title chore(wasm-instrument): rename syscall table tests to core-backend chore(wasm-instrument): move syscall table test to core-backend Nov 10, 2023
@clearloop
Copy link
Contributor Author

For some reason build was skipped but PR is still able to be merged? hm @clearloop

https://github.com/gear-tech/gear/pull/3460/checks?check_run_id=18188430376

@breathx breathx merged commit ed9a5b2 into master Nov 14, 2023
19 checks passed
@breathx breathx deleted the cl/rename-sys-call-tests branch November 14, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants