Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crates-io): introduce crates-io manager #3103

Merged
merged 61 commits into from
Nov 17, 2023
Merged

feat(crates-io): introduce crates-io manager #3103

merged 61 commits into from
Nov 17, 2023

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Aug 18, 2023 •
edited
Loading

Resolves #2832

  • list of all packages that need to be published
  • sort the packages in queue
  • specify the versions of dependencies in Cargo.toml ( with package cargo_toml )
  • rename gear-core-processor in demand
  • publish packages to crates-io
  • skip publishing if the package has already been published
  • handle crate-io limits for publishing
  • Dispatchable CI

show case: https://github.com/gear-tech/gear/actions/runs/6873627550/job/18693962567

@gear-tech/dev

@clearloop clearloop changed the title feat(crates-io): serialize packages to be published with version and … feat(crates-io): introduce crates-io manager Aug 18, 2023
@clearloop clearloop marked this pull request as ready for review August 19, 2023 15:59
@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Aug 19, 2023
@clearloop clearloop mentioned this pull request Aug 19, 2023
Closed
3 tasks
@clearloop clearloop mentioned this pull request Aug 21, 2023
Closed
@clearloop clearloop requested review from shamilsan and breathx August 23, 2023 08:07
@clearloop clearloop mentioned this pull request Aug 23, 2023
Closed
@clearloop clearloop mentioned this pull request Aug 31, 2023
Closed
@clearloop clearloop added the A5-dontmerge PR should not be merged yet label Aug 31, 2023
@clearloop
Copy link
Contributor Author

requires refactor after removing gear-backend-wasmi

@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Nov 1, 2023
@shamilsan shamilsan requested a review from breathx November 9, 2023 15:43
@breathx
Copy link
Member

breathx commented Nov 10, 2023

Waiting for #3460
And why was #3461 closed?

@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 10, 2023
@clearloop
Copy link
Contributor Author

Waiting for #3460 And why was #3461 closed?

I found that dev-dependencies as crates-io packages is not required for publishing, however, #3460 still makes sense since it cleans the deps of wasm-instrument

see the latest publish https://github.com/gear-tech/gear/actions/runs/6831922814/job/18582010768, everything still works

@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Nov 11, 2023
breathx
breathx requested changes Nov 14, 2023
View reviewed changes
gcli/tests/cmd/mod.rs Outdated Show resolved Hide resolved
gcli/tests/common/mod.rs Outdated Show resolved Hide resolved
sandbox/host/Cargo.toml Outdated Show resolved Hide resolved
utils/crates-io/publish.rs Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 14, 2023
breathx
breathx approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, waiting next pr with publishing of userspace libs

@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Nov 17, 2023
@clearloop clearloop merged commit 487252d into master Nov 17, 2023
10 checks passed
@clearloop clearloop deleted the cl/issue-2832 branch November 17, 2023 07:42
mqxf pushed a commit that referenced this pull request Nov 27, 2023
@clearloop @mqxf
feat(crates-io): introduce crates-io manager (#3103)
8aaedaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamilsan shamilsan shamilsan approved these changes

@breathx breathx breathx approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish gsdk, gcli, gclient to crates-io via CI
3 participants
@clearloop @breathx @shamilsan