Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm-gen): add limits for recursions and heavy loops #3391

Merged
merged 22 commits into from
Nov 19, 2023
Merged

feat(wasm-gen): add limits for recursions and heavy loops #3391

merged 22 commits into from
Nov 19, 2023

Conversation

StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Oct 4, 2023 •
edited
Loading

Resolves #3313

TODO:

  • tests on local machine
  • refactor code

@techraed
Copy link
Member

techraed commented Oct 7, 2023

please instrument loops too

@techraed techraed mentioned this pull request Oct 18, 2023
Closed
@breathx breathx added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Oct 22, 2023
@techraed
Copy link
Member

Actually resolving #3313

@techraed techraed mentioned this pull request Oct 28, 2023
Closed
@techraed techraed mentioned this pull request Nov 1, 2023
Open
@breathx
Copy link
Member

breathx commented Nov 10, 2023

"[ ] test fuzzer on server"?

@StackOverflowExcept1on StackOverflowExcept1on marked this pull request as ready for review November 13, 2023 13:25
@StackOverflowExcept1on StackOverflowExcept1on changed the title feat(wasm-gen): add limits for recursions feat(wasm-gen): add limits for recursions and heavy loops Nov 13, 2023
@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Nov 13, 2023
@techraed techraed mentioned this pull request Nov 14, 2023
Merged
1 task
breathx
breathx approved these changes Nov 14, 2023
View reviewed changes
utils/wasm-gen/src/utils.rs Outdated Show resolved Hide resolved
@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Nov 14, 2023
@breathx breathx requested a review from techraed November 14, 2023 21:40
techraed
techraed reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work done 🚀

utils/wasm-gen/src/config.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/tests.rs Show resolved Hide resolved
utils/wasm-gen/src/utils.rs Show resolved Hide resolved
@StackOverflowExcept1on StackOverflowExcept1on merged commit 7e8a664 into master Nov 19, 2023
10 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/wasm-gen-recursions branch November 19, 2023 07:42
@StackOverflowExcept1on StackOverflowExcept1on restored the av/wasm-gen-recursions branch November 19, 2023 09:36
mqxf pushed a commit that referenced this pull request Nov 27, 2023
@StackOverflowExcept1on @mqxf
feat(wasm-gen): add limits for recursions and heavy loops (#3391)
4564b8e
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/wasm-gen-recursions branch December 1, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@techraed techraed techraed approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instrument loops in wasms generated with wasm-gen with breaks
3 participants
@StackOverflowExcept1on @techraed @breathx