Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm-gen): Introduce precise gr_reply_deposit invocation #3483

Merged
merged 9 commits into from
Nov 29, 2023
Merged

feat(wasm-gen): Introduce precise gr_reply_deposit invocation #3483

merged 9 commits into from
Nov 29, 2023

Conversation

techraed
Copy link
Member

@techraed techraed commented Nov 8, 2023 •
edited
Loading

Resolves #3455 .

TODO:

  • Implement generation of a precise invocation of the gr_reply_deposit syscall
    ̶-̶ ̶[̶ ̶]̶ ̶I̶m̶p̶l̶e̶m̶e̶n̶t̶ ̶t̶e̶s̶t̶s̶

@techraed techraed added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D4-test Autotests, and examples D5-tooling Helper tools and utilities labels Nov 8, 2023
@techraed techraed self-assigned this Nov 8, 2023
@techraed
Copy link
Member Author

techraed commented Nov 8, 2023

Blocked until #3484 is merged.

@breathx
Copy link
Member

breathx commented Nov 10, 2023

Blocked until #3484 is merged.

Blocking PR is merged

@techraed techraed added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Nov 14, 2023
mertwole
mertwole approved these changes Nov 14, 2023
View reviewed changes
utils/wasm-gen/src/config/syscalls/precise.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/generator/syscalls/imports.rs Outdated Show resolved Hide resolved
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes A5-dontmerge PR should not be merged yet and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 14, 2023
@techraed
Copy link
Member Author

Blocked until #3448 and #3391 are merged.

@techraed techraed removed the A5-dontmerge PR should not be merged yet label Nov 28, 2023
@techraed techraed merged commit 2cf85ee into master Nov 29, 2023
10 checks passed
@techraed techraed deleted the st/issue-3455 branch November 29, 2023 08:35
@techraed techraed restored the st/issue-3455 branch February 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackOverflowExcept1on StackOverflowExcept1on StackOverflowExcept1on approved these changes

@breathx breathx breathx approved these changes

@mertwole mertwole mertwole approved these changes

Assignees

@techraed techraed

Labels
A2-mergeoncegreen PR is ready to merge after CI passes D4-test Autotests, and examples D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce precise syscall invocation for gr_reply_deposit
4 participants
@techraed @breathx @mertwole @StackOverflowExcept1on