Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdr 2199 #129

Merged
merged 22 commits into from
Feb 8, 2024
Merged

Gdr 2199 #129

merged 22 commits into from
Feb 8, 2024

Conversation

bczech
Copy link
Contributor

@bczech bczech commented Jan 3, 2024

Description

What changed?

Related JIRA issue: GDR-2199 and GDR-2244

Why was it changed?

To simplify logic of combo data and rename matrix into combination

Checklist for sustainable code base

  • I added tests for any code changed/added
  • I added documentation for any code changed/added
  • I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • Changelog updated

Screenshots (optional)

@bczech bczech requested a review from a team as a code owner January 3, 2024 12:22
@bczech bczech requested review from marcin-kam and darsoo and removed request for a team January 3, 2024 12:22
R/fit_SE.combinations.R Outdated Show resolved Hide resolved
Copy link
Contributor

@j-smola j-smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update package version

  • gDRtestData (>= 1.1.3)
  • gDRutils (>=1.1.3)
  • gDRcomponents (>=1.4.36)
  • gDRstyle(>=1.1.1)
  • gDRimport(>=1.1.4)

R/combinations-calculate_matrix_metric.R Show resolved Hide resolved
R/combinations-calculate_matrix_metric.R Show resolved Hide resolved
R/combinations-calculate_matrix_metric.R Outdated Show resolved Hide resolved
R/combinations-calculate_matrix_metric.R Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
@bczech bczech merged commit 135f636 into master Feb 8, 2024
3 of 4 checks passed
@bczech bczech deleted the GDR-2199 branch February 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants