Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Combat UI #219

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Add Combat UI #219

merged 6 commits into from
Sep 16, 2024

Conversation

food-please
Copy link
Contributor

@food-please food-please commented Sep 15, 2024

Another PR looking to address the Combat issue.

The following PR adds combat UI elements, including:

  • Damage/"Miss" labels on action impact
  • A turn bar to display Battler turn order in real-time
  • A list of player Battlers

As before, much of the work is derived from the 2D Secrets course. I don't think there's anything terribly surprising here, though I tried to simplify the BattlerAnim class before implementing these changes.

Note - There is a second half to the combat UI to be updated: This PR does not yet allow for the players to select actions, simply because that is (just a little) more involved and could have its own PR or be implemented prior to merging this PR. Finally, combat results screens will be another necessary update to the combat UI before moving to other game components.

Also a Note - I keep updating Dialogic which then includes thousands of changes in each PR. I'm not sure if that's helpful or not.

@food-please
Copy link
Contributor Author

combat_ui

@NathanLovato
Copy link
Contributor

Thank you! No need to update dialogic. Generally, if there are no bugs or needed new features, it's fine to keep a plugin or dependency locked to its current version in a software project.

Merging now and I'll add minor refactoring changes to main afterwards as I can't directly push changes to your repository. Please be sure to update to the latest commit afterwards.

@NathanLovato NathanLovato merged commit 8d0783a into gdquest-demos:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants