Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel updates for Garden build #1239

Merged
merged 31 commits into from
Dec 13, 2023
Merged

Bazel updates for Garden build #1239

merged 31 commits into from
Dec 13, 2023

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Feb 10, 2023 •
edited
Loading

Updates bazel build for gazebo garden vesions. Also cleans up a few places where we were hardcoding Cmake variables.

@mjcarroll mjcarroll mentioned this pull request Feb 10, 2023
Open
33 tasks
@mjcarroll mjcarroll changed the base branch from main to sdf13 February 16, 2023 16:57
@Bi0T1N @mjcarroll
Cherry-pick the python3 embedSdf script and tests (#884)
07e9161 
These won't be used as part of the cmake build on this branch, but are
useful for generating the same file from bazel.

Co-authored-by: Bi0T1N <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Improvements to embedSdf script
09d69f4 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll changed the base branch from sdf13 to mjcarroll/backport_embedsdf February 16, 2023 18:48
@mjcarroll @azeey
Update sdf/CMakeLists.txt
a82e65f 
Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
@mjcarroll mjcarroll self-assigned this Feb 16, 2023
@mjcarroll mjcarroll marked this pull request as ready for review February 16, 2023 19:05
@mjcarroll
Update bazel files
7553e0f 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Lint
607918f 
Signed-off-by: Michael Carroll <[email protected]>
Base automatically changed from mjcarroll/backport_embedsdf to sdf13 February 17, 2023 19:05
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@mjcarroll
Bazel nits
0f6044a 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix path logic
c9a1b85 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix visibility
cc8a96a 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix strings
119cabd 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Use standard vars
5c854ea 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix string conversions
a774176 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix string conversions
17d12ec 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix embedded sdf
1212060 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Merge remote-tracking branch 'origin/mjcarroll/garden_bazel' into mjc…
b5148eb 
…arroll/garden_bazel
@mjcarroll
Fix converter test
d0062f5 
Signed-off-by: Michael Carroll <[email protected]>
@azeey
Copy link
Collaborator

azeey commented Aug 10, 2023

I'm getting an error

$ bazel build //...
ERROR: Traceback (most recent call last):
        File "/home/addisuzt/ws/gz-bazel-src/sdformat/BUILD.bazel", line 6, column 6, in <toplevel>
                "add_lint_tests",
Error: file '@gz//bazel/skylark:build_defs.bzl' does not contain symbol 'add_lint_tests'
ERROR: package contains errors: sdformat
ERROR: package contains errors: sdformat: Traceback (most recent call last):
        File "/home/addisuzt/ws/gz-bazel-src/sdformat/BUILD.bazel", line 6, column 6, in <toplevel>
                "add_lint_tests",
Error: file '@gz//bazel/skylark:build_defs.bzl' does not contain symbol 'add_lint_tests'
ERROR: Skipping '//...': Error evaluating '//...': error loading package 'sdformat': Package 'sdformat' contains errors
WARNING: Target pattern parsing failed.
ERROR: Error evaluating '//...': error loading package 'sdformat': Package 'sdformat' contains errors
INFO: Elapsed time: 0.562s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (78 packages loaded)

I followed the instructions in the gz-bazel repo. Not sure if I'm doing something wrong.

@mjcarroll
Copy link
Contributor Author

mjcarroll commented Aug 10, 2023 via email

@mjcarroll mjcarroll added 🌱 garden Ignition Garden and removed beta Targeting beta release of upcoming collection labels Aug 28, 2023
@j-rivero
Copy link
Contributor

j-rivero commented Oct 6, 2023

@osrf-jenkins run tests

@mjcarroll
Update bazel files
3d4e590 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Merge branch 'sdf13' into mjcarroll/garden_bazel
d143957 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Add detail prefix
53732ed 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix test path
874d4a4 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

@azeey I think this one is ready for another look

@mjcarroll mjcarroll mentioned this pull request Dec 7, 2023
Merged
@mjcarroll mjcarroll merged commit a20cf95 into sdf13 Dec 13, 2023
13 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/garden_bazel branch December 13, 2023 14:59
@traversaro traversaro mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

@mjcarroll mjcarroll

Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjcarroll @azeey @j-rivero @iche033 @Bi0T1N