-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly gather version information from git #37
Conversation
18ec6d7
to
b09292a
Compare
19dfe1c
to
d7615ab
Compare
d7615ab
to
f9007de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should never be needed! if we have dependecies on other self build packages these should always be explicit through the dependencies
input of the build_pkg.yml
or locally the /pkgs
mount in the container. otherwise we would once again have the problem with needing an incrementally build repo
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #29 #30
Special notes for your reviewer:
Release note: