Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly gather version information from git #37

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

alee-ntap
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #29 #30

Special notes for your reviewer:

Release note:

container/bin/build_source Outdated Show resolved Hide resolved
container/bin/build_source Outdated Show resolved Hide resolved
container/bin/build_source Outdated Show resolved Hide resolved
container/bin/build_source Outdated Show resolved Hide resolved
container/bin/build_source Outdated Show resolved Hide resolved
container/bin/build_source Outdated Show resolved Hide resolved
container/bin/build_source Outdated Show resolved Hide resolved
@nanory nanory changed the title Feature/29 create changelog Properly gather version information from git Dec 1, 2023
@alee-ntap alee-ntap force-pushed the feature/29-create-changelog branch from 18ec6d7 to b09292a Compare December 1, 2023 13:41
@nanory nanory force-pushed the feature/29-create-changelog branch 6 times, most recently from 19dfe1c to d7615ab Compare December 1, 2023 15:07
@nanory nanory force-pushed the feature/29-create-changelog branch from d7615ab to f9007de Compare December 1, 2023 16:16
Copy link
Contributor

@nanory nanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanory nanory merged commit df5f85a into main Dec 1, 2023
3 of 4 checks passed
@nanory nanory deleted the feature/29-create-changelog branch December 1, 2023 16:27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should never be needed! if we have dependecies on other self build packages these should always be explicit through the dependencies input of the build_pkg.yml or locally the /pkgs mount in the container. otherwise we would once again have the problem with needing an incrementally build repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All gardenlinux package use git source without based on debian are failed due to missing debian/changelog.
3 participants