Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The get_version() function in build_source script should be extended to know the latest upstream from git tag #30

Closed
alee-ntap opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@alee-ntap
Copy link
Contributor

What would you like to be added:

I would like to extend the get_version() function in the build_source script to fetch the latest upstream version from git tags when using git as the upstream source.

Why is this needed:

After investigated on #29 ,
it has been identified that the --create --package $name command results in a version string of gardenlinux~$commit-hash, for example:

+ dch --create --package aws-sdk-cpp --newversion gardenlinux~45805daa1be4515729a226b037e00a726076bb90 --distribution gardenlinux --force-distribution -- 'Rebuild for Garden Linux.' 

To improve the versioning process, it is necessary to modify the get_version() function to fetch the latest upstream version from git tags. This will ensure more accurate and meaningful versioning for the packages.

@alee-ntap alee-ntap added the kind/enhancement Enhancement, improvement, extension label Nov 29, 2023
@nanory
Copy link
Contributor

nanory commented Dec 4, 2023

This task has been completed by #37
I'm closing this issue.

@nanory nanory closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants