Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed String.startsWith !FABLE_COMPILER condition #611

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Removed String.startsWith !FABLE_COMPILER condition #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e35cde
Removed String.startsWith FABLE_COMPILER condition
laurentpayot Oct 29, 2024
a5edf14
Fable updated to 4.23.0
laurentpayot Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"fable": {
"version": "4.5.0",
"version": "4.23.0",
"commands": [
"fable"
]
Expand Down
3 changes: 0 additions & 3 deletions src/FSharpPlus/Extensions/String.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,12 @@ module String =

source.Contains subString

#if !FABLE_COMPILER

/// Does the source string start with the given subString? -- function wrapper for String.StartsWith method using InvariantCulture.
let startsWith (subString: string) (source: string) =
raiseIfNull (nameof subString) subString
raiseIfNull (nameof source) source

source.StartsWith (subString, false, CultureInfo.InvariantCulture)
#endif

/// Does the source string end with the given subString? -- function wrapper for String.EndsWith method using InvariantCulture.
let endsWith subString (source: string) =
Expand Down
Loading