Removed String.startsWith !FABLE_COMPILER condition #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to update fable as well? |
|
@wallymathieu Oopsie. Yes, I just bumped Fable to version 4.23.0 so the fix is included. |
wallymathieu
approved these changes
Oct 31, 2024
wallymathieu
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Removed String.startsWith FABLE_COMPILER condition * Fable updated to 4.23.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I had an error with
String.endsWithwhen compiling a project using FSharpPlus with Fable.String.endsWithwas not surrounded by a!FABLE_COMPILERsymbol condition.A Fable maintainer fixed my issue by making
String.endsWithwork with Fable, as well asString.startsWith.This PR simply removes the
!FABLE_COMPILERsymbol condition aroundString.startsWiththat is not needed anymore.