Stub method shared tests

test/acceptance/acceptance_test_helper.rb

@@ -38,5 +38,9 @@ def teardown_acceptance_test
     Mocha::Configuration.reset_configuration
   end
 
+  def assert_passed_with_snapshot_unchanged(object, &block)
+    assert_snapshot_unchanged(object) { assert_passed(run_as_test(&block)) }
+  end
+
   include Introspection::Assertions
 end

test/acceptance/prepend_test.rb

@@ -47,37 +47,28 @@ def my_method
     end
 
     def test_stubbing_any_instance_with_multiple_prepended_methods
-      assert_snapshot_unchanged(Klass1) do
-        test_result = run_as_test do
-          Klass1.any_instance.stubs(:my_method).returns('Bye World')
-          assert_equal 'Bye World', Klass1.new.my_method
-        end
-        assert_passed(test_result)
+      assert_passed_with_snapshot_unchanged(Klass1) do
+        Klass1.any_instance.stubs(:my_method).returns('Bye World')
+        assert_equal 'Bye World', Klass1.new.my_method
       end
       assert_equal 'Hello World Wide', Klass1.new.my_method
     end
 
     def test_stubbing_instance_with_multiple_prepended_methods
       object = Klass1.new
 
-      assert_snapshot_unchanged(object) do
-        test_result = run_as_test do
-          object.stubs(:my_method).returns('Bye World')
-          assert_equal 'Bye World', object.my_method
-          assert_equal 'Hello World Wide', Klass1.new.my_method
-        end
-        assert_passed(test_result)
+      assert_passed_with_snapshot_unchanged(object) do
+        object.stubs(:my_method).returns('Bye World')
+        assert_equal 'Bye World', object.my_method
+        assert_equal 'Hello World Wide', Klass1.new.my_method
       end
       assert_equal 'Hello World Wide', object.my_method
     end
 
     def test_stubbing_a_prepended_class_method
-      assert_snapshot_unchanged(Klass2) do
-        test_result = run_as_test do
-          Klass2.stubs(:my_method).returns('Bye World')
-          assert_equal 'Bye World', Klass2.my_method
-        end
-        assert_passed(test_result)
+      assert_passed_with_snapshot_unchanged(Klass2) do
+        Klass2.stubs(:my_method).returns('Bye World')
+        assert_equal 'Bye World', Klass2.my_method
       end
       assert_equal 'Hello World Wide', Klass2.my_method
     end

test/acceptance/stub_any_instance_method_defined_on_superclass_test.rb

@@ -1,33 +1,18 @@
-require File.expand_path('../acceptance_test_helper', __FILE__)
+require File.expand_path('../stub_method_shared_tests', __FILE__)
 
 class StubAnyInstanceMethodDefinedOnSuperclassTest < Mocha::TestCase
-  include AcceptanceTest
+  include StubMethodSharedTests
 
-  def setup
-    setup_acceptance_test
+  def method_owner
+    callee.class.superclass
   end
 
-  def teardown
-    teardown_acceptance_test
+  def callee
+    @callee ||= Class.new(Class.new).new
   end
 
-  def test_should_stub_method_and_leave_it_unchanged_after_test
-    superklass = Class.new do
-      def my_superclass_method
-        :original_return_value
-      end
-      public :my_superclass_method
-    end
-    klass = Class.new(superklass)
-    instance = klass.new
-    assert_snapshot_unchanged(instance) do
-      test_result = run_as_test do
-        superklass.any_instance.stubs(:my_superclass_method).returns(:new_return_value)
-        assert_equal :new_return_value, instance.my_superclass_method
-      end
-      assert_passed(test_result)
-    end
-    assert_equal :original_return_value, instance.my_superclass_method
+  def stubbee
+    callee.class.any_instance
   end
 
   def test_expect_method_on_any_instance_of_superclass_even_if_preceded_by_test_expecting_method_on_any_instance_of_subclass
@@ -62,3 +47,19 @@ def my_instance_method; end
     ], test_result.failure_message_lines
   end
 end
+
+class StubSuperclassAnyInstanceMethodDefinedOnSuperclassTest < Mocha::TestCase
+  include StubMethodSharedTests
+
+  def method_owner
+    callee.class.superclass
+  end
+
+  def callee
+    @callee ||= Class.new(Class.new).new
+  end
+
+  def stubbee
+    method_owner.any_instance
+  end
+end

test/acceptance/stub_any_instance_method_test.rb

@@ -1,137 +1,18 @@
-require File.expand_path('../acceptance_test_helper', __FILE__)
+require File.expand_path('../stub_method_shared_tests', __FILE__)
 
 class StubAnyInstanceMethodTest < Mocha::TestCase
-  include AcceptanceTest
+  include StubMethodSharedTests
 
-  def setup
-    setup_acceptance_test
+  def method_owner
+    @method_owner ||= Class.new
   end
 
-  def teardown
-    teardown_acceptance_test
+  def callee
+    method_owner.new
   end
 
-  def test_should_stub_public_method_within_test
-    klass = Class.new do
-      def my_instance_method
-        :original_return_value
-      end
-    end
-    instance = klass.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:my_instance_method).returns(:new_return_value)
-      assert_method_visibility instance, :my_instance_method, :public
-      assert_equal :new_return_value, instance.my_instance_method
-    end
-    assert_passed(test_result)
-  end
-
-  def test_should_leave_stubbed_public_method_unchanged_after_test
-    klass = Class.new do
-      def my_instance_method
-        :original_return_value
-      end
-      public :my_instance_method
-      def self.public(*args); end
-    end
-    instance = klass.new
-    run_as_test do
-      klass.any_instance.stubs(:my_instance_method).returns(:new_return_value)
-    end
-    assert(instance.public_methods(false).any? { |m| m.to_s == 'my_instance_method' })
-    assert_equal :original_return_value, instance.my_instance_method
-  end
-
-  def test_should_leave_stubbed_public_method_unchanged_after_test_when_it_was_originally_private_in_owning_module
-    module_with_private_method = Module.new do
-      def my_included_method
-        :original_return_value
-      end
-      private :my_included_method
-    end
-    klass = Class.new do
-      include module_with_private_method
-      public :my_included_method
-    end
-    instance = klass.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:my_included_method).returns(:new_return_value)
-      assert_equal :new_return_value, instance.my_included_method
-    end
-    assert_passed(test_result)
-    assert_equal :original_return_value, instance.my_included_method
-  end
-
-  def test_should_leave_stubbed_protected_method_unchanged_after_test
-    klass = Class.new do
-      def my_instance_method
-        :original_return_value
-      end
-      protected :my_instance_method
-      def self.protected(*args); end
-
-      def my_unprotected_instance_method
-        my_instance_method
-      end
-    end
-    instance = klass.new
-    run_as_test do
-      klass.any_instance.stubs(:my_instance_method).returns(:new_return_value)
-    end
-    assert(instance.protected_methods(false).any? { |m| m.to_s == 'my_instance_method' })
-    assert_equal :original_return_value, instance.my_unprotected_instance_method
-  end
-
-  def test_should_stub_protected_method_within_test
-    klass = Class.new do
-      def my_instance_method
-        :original_return_value
-      end
-      protected :my_instance_method
-      def self.protected(*args); end
-
-      def my_unprotected_instance_method
-        my_instance_method
-      end
-    end
-    instance = klass.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:my_instance_method).returns(:new_return_value)
-      assert_method_visibility instance, :my_instance_method, :protected
-    end
-    assert_passed(test_result)
-  end
-
-  def test_should_leave_stubbed_private_method_unchanged_after_test
-    klass = Class.new do
-      def my_instance_method
-        :original_return_value
-      end
-      private :my_instance_method
-      def self.private(*args); end
-    end
-    instance = klass.new
-    run_as_test do
-      klass.any_instance.stubs(:my_instance_method).returns(:new_return_value)
-    end
-    assert(instance.private_methods(false).any? { |m| m.to_s == 'my_instance_method' })
-    assert_equal :original_return_value, instance.send(:my_instance_method)
-  end
-
-  def test_should_stub_private_method_within_test
-    klass = Class.new do
-      def my_instance_method
-        :original_return_value
-      end
-      private :my_instance_method
-      def self.private(*args); end
-    end
-    instance = klass.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:my_instance_method).returns(:new_return_value)
-      assert_method_visibility instance, :my_instance_method, :private
-    end
-    assert_passed(test_result)
+  def stubbee
+    method_owner.any_instance
   end
 
   def test_should_reset_expectations_after_test
@@ -147,66 +28,6 @@ def my_instance_method
     assert_equal 0, klass.any_instance.mocha.__expectations__.length
   end
 
-  def test_should_be_able_to_stub_a_public_superclass_method
-    superklass = Class.new do
-      def my_superclass_method
-        :original_return_value
-      end
-      public :my_superclass_method
-    end
-    klass = Class.new(superklass)
-    instance = klass.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:my_superclass_method).returns(:new_return_value)
-      assert_method_visibility instance, :my_superclass_method, :public
-      assert_equal :new_return_value, instance.my_superclass_method
-    end
-    assert_passed(test_result)
-    assert(instance.public_methods(true).any? { |m| m.to_s == 'my_superclass_method' })
-    assert(klass.public_methods(false).none? { |m| m.to_s == 'my_superclass_method' })
-    assert_equal :original_return_value, instance.my_superclass_method
-  end
-
-  def test_should_be_able_to_stub_a_protected_superclass_method
-    superklass = Class.new do
-      def my_superclass_method
-        :original_return_value
-      end
-      protected :my_superclass_method
-    end
-    klass = Class.new(superklass)
-    instance = klass.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:my_superclass_method).returns(:new_return_value)
-      assert_method_visibility instance, :my_superclass_method, :protected
-      assert_equal :new_return_value, instance.send(:my_superclass_method)
-    end
-    assert_passed(test_result)
-    assert(instance.protected_methods(true).any? { |m| m.to_s == 'my_superclass_method' })
-    assert(klass.protected_methods(false).none? { |m| m.to_s == 'my_superclass_method' })
-    assert_equal :original_return_value, instance.send(:my_superclass_method)
-  end
-
-  def test_should_be_able_to_stub_a_private_superclass_method
-    superklass = Class.new do
-      def my_superclass_method
-        :original_return_value
-      end
-      private :my_superclass_method
-    end
-    klass = Class.new(superklass)
-    instance = klass.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:my_superclass_method).returns(:new_return_value)
-      assert_method_visibility instance, :my_superclass_method, :private
-      assert_equal :new_return_value, instance.send(:my_superclass_method)
-    end
-    assert_passed(test_result)
-    assert(instance.private_methods(true).any? { |m| m.to_s == 'my_superclass_method' })
-    assert(klass.private_methods(false).none? { |m| m.to_s == 'my_superclass_method' })
-    assert_equal :original_return_value, instance.send(:my_superclass_method)
-  end
-
   # rubocop:disable Lint/DuplicateMethods
   def test_should_be_able_to_stub_method_if_ruby18_public_instance_methods_include_method_but_method_does_not_actually_exist_like_active_record_association_proxy
     ruby18_klass = Class.new do
@@ -299,3 +120,26 @@ def private_instance_methods(_include_superclass = true)
   end
   # rubocop:enable Lint/DuplicateMethods
 end
+
+class StubAnyInstanceMethodOriginallyPrivateInOwningModuleTest < Mocha::TestCase
+  include StubMethodSharedTests
+
+  def method_owner
+    @method_owner ||= Class.new.send(:include, module_with_private_method)
+  end
+
+  def callee
+    method_owner.new
+  end
+
+  def stubbee
+    method_owner.any_instance
+  end
+
+  def module_with_private_method
+    mod = Module.new
+    mod.send(:define_method, stubbed_method_name) { :private_module_method_return_value }
+    mod.send(:private, stubbed_method_name)
+    mod
+  end
+end