-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub method shared tests #458
base: main
Are you sure you want to change the base?
Commits on Feb 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c203058 - Browse repository at this point
Copy the full SHA c203058View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36888e8 - Browse repository at this point
Copy the full SHA 36888e8View commit details -
prep to DRY by using send instead of direct invocation
... making it identical to protected and private method cases
Configuration menu - View commit details
-
Copy full SHA for c455732 - Browse repository at this point
Copy the full SHA c455732View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2362c5 - Browse repository at this point
Copy the full SHA d2362c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26de50e - Browse repository at this point
Copy the full SHA 26de50eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fe3702 - Browse repository at this point
Copy the full SHA 6fe3702View commit details -
Configuration menu - View commit details
-
Copy full SHA for fec664a - Browse repository at this point
Copy the full SHA fec664aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c47db1 - Browse repository at this point
Copy the full SHA 9c47db1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90570ec - Browse repository at this point
Copy the full SHA 90570ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32562f1 - Browse repository at this point
Copy the full SHA 32562f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e425af - Browse repository at this point
Copy the full SHA 2e425afView commit details -
allow instantiation to be parameterized by subclassing
This will allow us to reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnClassTest (and perhaps others)
Configuration menu - View commit details
-
Copy full SHA for 0d024d4 - Browse repository at this point
Copy the full SHA 0d024d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44037fe - Browse repository at this point
Copy the full SHA 44037feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 388c608 - Browse repository at this point
Copy the full SHA 388c608View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8505d1 - Browse repository at this point
Copy the full SHA b8505d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60036df - Browse repository at this point
Copy the full SHA 60036dfView commit details -
split StubInstanceMethodDefinedOnKernelModuleTest into two
This allows us to reuse StubInstanceMethodSharedTests for checking stubbing on a Module and stubbing on an object
Configuration menu - View commit details
-
Copy full SHA for e9cfc66 - Browse repository at this point
Copy the full SHA e9cfc66View commit details -
return stubbed instance instead of stubbed class
This will allow us to reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnSingletonClass as instead of creating an instance from a class there, we obtain the (singleton) class from the instance.
Configuration menu - View commit details
-
Copy full SHA for eef3880 - Browse repository at this point
Copy the full SHA eef3880View commit details -
Configuration menu - View commit details
-
Copy full SHA for a84b186 - Browse repository at this point
Copy the full SHA a84b186View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc1d2f - Browse repository at this point
Copy the full SHA adc1d2fView commit details -
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnCla…
…ssAndAliasedTest
Configuration menu - View commit details
-
Copy full SHA for bffb23d - Browse repository at this point
Copy the full SHA bffb23dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1180f77 - Browse repository at this point
Copy the full SHA 1180f77View commit details -
reuse StubInstanceMethodSharedTests in StubClassMethod*Test
...since class methods are just instance methods of the singleton class of class
Configuration menu - View commit details
-
Copy full SHA for ba0617b - Browse repository at this point
Copy the full SHA ba0617bView commit details -
allow stub_owner to be different from stubbed_instance
This will allow us to, for instance, stub a method on a superclass but check the stubbed method on its child
Configuration menu - View commit details
-
Copy full SHA for 6d3b047 - Browse repository at this point
Copy the full SHA 6d3b047View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ea322e - Browse repository at this point
Copy the full SHA 0ea322eView commit details -
remove 'instance' qualifier from shared tests
... since it is now used for instance as well as class methods
Configuration menu - View commit details
-
Copy full SHA for 6a0bbc3 - Browse repository at this point
Copy the full SHA 6a0bbc3View commit details -
reuse StubMethodSharedTests in StubModuleMethodTest
... and delete test_should_stub_method_within_test as covered by checks in StubMethodSharedTests
Configuration menu - View commit details
-
Copy full SHA for 060ebb7 - Browse repository at this point
Copy the full SHA 060ebb7View commit details -
reuse StubMethodSharedTests in StubAnyInstanceMethodTest
delete test_should_stub_*_method_within_test as already covered by checks in StubMethodSharedTests
Configuration menu - View commit details
-
Copy full SHA for 1b5af22 - Browse repository at this point
Copy the full SHA 1b5af22View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdc2e2b - Browse repository at this point
Copy the full SHA fdc2e2bView commit details -
use shared tests for AnyInstance superclass checks
... while moving them from stub_any_instance_method_test to stub_any_instance_method_defined_on_superclass_test
Configuration menu - View commit details
-
Copy full SHA for 620ff24 - Browse repository at this point
Copy the full SHA 620ff24View commit details -
delete test_should_be_able_to_stub_a_superclass_method
It wasn't checking stubbing of a supeclass or even a supermodule method. self.my_superclass_method from supermod isn't inherited/included in mod. So, all that it checked was that you could stub a non-existent module method.
Configuration menu - View commit details
-
Copy full SHA for 99ca183 - Browse repository at this point
Copy the full SHA 99ca183View commit details -
extract assert_passed_with_snapshot_unchanged
... to DRY up assert_snapshot_unchanged + run_as_test + assert_passed combo
Configuration menu - View commit details
-
Copy full SHA for aad1b3f - Browse repository at this point
Copy the full SHA aad1b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18c8c49 - Browse repository at this point
Copy the full SHA 18c8c49View commit details