HRIS-361 [Task] Implement second tranche of PR comments

README.md

@@ -52,6 +52,7 @@ HRIS is an internal project for the admin team of Sun Asterisk PH that aims to h
 3. cp .env.api.example .env.api
 4. cp .env.client.example .env.client
 5. cp .env.db.example .env.db
+5. cp .env.api_v2.example .env.api_v2
 6. `docker compose build` or `docker compose up --build` (this will automatically build and run the containers)
 7. `docker compose up` (To stop docker containers, run: `docker compose down`)
 
@@ -74,4 +75,5 @@ HRIS is an internal project for the admin team of Sun Asterisk PH that aims to h
 - Run `cp .env.api_v2.example .env.api_v2` to create a local env for NestJS
 - In .env.api_v2, supply the blank fields with the necessary values
 - Run `npm install` to install the dependencies
-- Run `npm run dev` to run the app manually
+- Run `npm run dev` to run the app manually
+  - Note: 

api_v2/.husky/pre-commit

@@ -1,3 +1,3 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
-cd ./api_v2 && npm test
+cd ./api_v2 && npm test && npm run lint

api_v2/package.json

@@ -12,7 +12,8 @@
     "dev": "nest start --watch",
     "dev:debug": "nest start --debug --watch",
     "start:prod": "node dist/main",
-    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
+    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\"",
+    "lint:fix": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
     "test": "jest",
     "test:watch": "jest --watch",
     "test:cov": "jest --coverage",

api_v2/src/app.resolver.ts

@@ -3,10 +3,10 @@ import { AppService } from './app.service';
 
 @Resolver()
 export class AppResolver {
-    constructor(private readonly appService: AppService) {}
+  constructor(private readonly appService: AppService) {}
 
-    @Query(() => String)
-    getHello(): string {
-        return this.appService.getHello();
-      }
+  @Query(() => String)
+  getHello(): string {
+    return this.appService.getHello();
+  }
 }

docker-compose.yml

@@ -19,7 +19,7 @@ services:
     depends_on:
       - db
 
-  # ASP.NET Service
+  # NestJS Service
   api_v2:
     build:
       context: ./api_v2