HRIS-361 [Task] Implement PR Comments

README.md

@@ -74,4 +74,4 @@ HRIS is an internal project for the admin team of Sun Asterisk PH that aims to h
 - Run `cp .env.api_v2.example .env.api_v2` to create a local env for NestJS
 - In .env.api_v2, supply the blank fields with the necessary values
 - Run `npm install` to install the dependencies
-- Run `npm run start:dev` to run the app manually
+- Run `npm run dev` to run the app manually

api_v2/.env.example

@@ -0,0 +1 @@
+JWT_SECRET_KEY=

api_v2/Dockerfile

@@ -11,4 +11,4 @@ COPY . /usr/src/api_v2/
 
 EXPOSE 3001
 
-ENTRYPOINT ["npm", "run", "start:dev"]
+ENTRYPOINT ["npm", "run", "dev"]

api_v2/README.md

@@ -39,7 +39,7 @@ $ npm install
 $ npm run start
 
 # watch mode
-$ npm run start:dev
+$ npm run dev
 
 # production mode
 $ npm run start:prod

api_v2/package.json

@@ -9,8 +9,8 @@
     "build": "nest build",
     "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
     "start": "nest start",
-    "start:dev": "nest start --watch",
-    "start:debug": "nest start --debug --watch",
+    "dev": "nest start --watch",
+    "dev:debug": "nest start --debug --watch",
     "start:prod": "node dist/main",
     "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
     "test": "jest",

api_v2/src/graphql/schema.gql

@@ -0,0 +1,7 @@
+# ------------------------------------------------------
+# THIS FILE WAS AUTOMATICALLY GENERATED (DO NOT MODIFY)
+# ------------------------------------------------------
+
+type Query {
+  getHello: String!
+}

api_v2/tsconfig.json

@@ -12,10 +12,14 @@
     "baseUrl": "./",
     "incremental": true,
     "skipLibCheck": true,
-    "strictNullChecks": false,
-    "noImplicitAny": false,
+    "strictNullChecks": true,
+    "noImplicitAny": true,
     "strictBindCallApply": false,
     "forceConsistentCasingInFileNames": false,
-    "noFallthroughCasesInSwitch": false
-  }
+    "noFallthroughCasesInSwitch": false,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "paths": { "@/*": ["src/*"] }
+  },
+  "exclude": ["node_modules", "dist"]
 }