Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an RBAC-free machanism in the driver #21

Merged
merged 1 commit into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ docker-push: ## Push docker image with the manager.
docker-push-driver: ## Push docker image with the manager.
$(CONTAINER_TOOL) push ${IMG_DRIVER}

.PHONY: proto
proto: ## generate GRPC client and server code
protoc --experimental_allow_proto3_optional --go_out=. --go_opt=paths=source_relative --go-grpc_out=. \
--go-grpc_opt=paths=source_relative backend/api/v1beta1/update_status.proto

# PLATFORMS defines the target platforms for the manager image be built to provide support to multiple
# architectures. (i.e. make docker-buildx IMG=myregistry/mypoperator:0.0.1). To use this option you need to:
# - be able to use docker buildx. More info: https://docs.docker.com/build/buildx/
Expand Down
344 changes: 344 additions & 0 deletions backend/api/v1beta1/update_status.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 41 additions & 0 deletions backend/api/v1beta1/update_status.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Copyright 2024.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

syntax = "proto3";

option go_package = "github.com/foundation-model-stack/fms-lm-eval-service/backend/api/v1beta1";

enum ResponseCode {
OK = 0;
ERROR = 1;
}

// the JobState, Reason, message, and optional Results
message JobStatus {
string job_name = 1;
string job_namespace = 2;
gabe-l-hart marked this conversation as resolved.
Show resolved Hide resolved
string state = 3;
string reason = 4;
string status_message = 5;
optional string results = 6;
}

message Response {
ResponseCode code = 1;
string message = 2;
}

service LMEvalJobUpdateService {
rpc UpdateStatus(JobStatus) returns (Response);
}
Loading
Loading