Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement an RBAC-free machanism in the driver #21

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Implement an RBAC-free machanism in the driver #21

merged 1 commit into from
Jul 11, 2024

Conversation

yhwang
Copy link
Collaborator

@yhwang yhwang commented Jul 3, 2024 •
edited
Loading

Create a gRPC server in the controller to receive
the status updates from the driver to avoid the RBAC for the driver Pod.

  • Add gRPC server in the controller
  • Use mTLS or TLS as the secured protocol
  • Update the driver to use the gRPC client to update the status

related: #10

gabe-l-hart
gabe-l-hart reviewed Jul 3, 2024
View reviewed changes
Copy link

@gabe-l-hart gabe-l-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of this! It looks really good and nicely solves the RBAC problem. A pile of little thoughts/NITs, none of which look like show stoppers (except possibly the Dockerfile hard-code hash).

backend/api/v1beta1/update_status.proto Outdated Show resolved Hide resolved
backend/api/v1beta1/update_status.proto Show resolved Hide resolved
backend/api/v1beta1/update_status.proto Outdated Show resolved Hide resolved
backend/controller/grpc_server.go Show resolved Hide resolved
backend/controller/grpc_server.go Show resolved Hide resolved
backend/controller/lmevaljob_controller.go Show resolved Hide resolved
backend/driver/driver_test.go Show resolved Hide resolved
config/manager/manager.yaml Show resolved Hide resolved
config/rbac/driver_role.yaml Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@yhwang
Implement an RBAC-free machanism in the driver
759833b 
Create a gRPC server in the controller to receive
the status updates from the driver to avoid the RBAC
for the driver Pod.
- Add gRPC server in the controller
- Use mTLS or TLS as the secured protocol
- Update the driver to use the gRPC client
  to update the status

Signed-off-by: Yihong Wang <[email protected]>
@yhwang yhwang requested a review from gabe-l-hart July 3, 2024 18:04
gabe-l-hart
gabe-l-hart approved these changes Jul 11, 2024
View reviewed changes
Copy link

@gabe-l-hart gabe-l-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very nice solution to this

@yhwang yhwang merged commit e6b8f73 into main Jul 11, 2024
3 checks passed
@yhwang yhwang deleted the rbac-free branch July 11, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-l-hart gabe-l-hart gabe-l-hart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhwang @gabe-l-hart