Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream changes to fix token validity and utilizing inmemory creds source #6001

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Upstream changes to fix token validity and utilizing inmemory creds source #6001

merged 3 commits into from
Nov 14, 2024

Commits on Nov 13, 2024

  1. Auth/prevent lookup per call (#5686) (#555) 

    Cherry-pick the following change to populate oauth metadata once on initialization using Sync.Do
ca04314

Tested locally using uctl-admin and fetched projects calling into admin which exercises the auth flow
https://buildkite.com/unionai/org-staging-sync/builds/3541

Rollout to all canary and then prod tenants

- [x] To be upstreamed to OSS

*TODO: Link Linear issue(s) using [magic words](https://linear.app/docs/github#magic-words). `fixes` will move to merged status, while `ref` will only link the PR.*

* [ ] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation

Signed-off-by: pmahindrakar-oss <[email protected]>
    @pmahindrakar-oss
    pmahindrakar-oss committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9bcaad2 View commit details
    Browse the repository at this point in the history

  2. [COR-1114] Fix token validity check logic to use exp field in access … 

    …token (#330)

* Add logs for token

* add logs

* Fixing the validity check logic for token

* nit

* nit

* Adding in memory token source provider

* nit

* changed Valid method to log and ignore parseDateClaim error

* nit

* Fix unit tests

* lint

* fix unit tests

Signed-off-by: pmahindrakar-oss <[email protected]>
    @pmahindrakar-oss
    pmahindrakar-oss committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    306a447 View commit details
    Browse the repository at this point in the history

  3. remove debug logs 

    Signed-off-by: pmahindrakar-oss <[email protected]>
    @pmahindrakar-oss
    pmahindrakar-oss committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    29e31d3 View commit details
    Browse the repository at this point in the history