Upstream changes to fix token validity and utilizing inmemory creds source #6001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6001 +/- ##
==========================================
+ Coverage 36.95% 36.97% +0.02%
==========================================
Files 1310 1312 +2
Lines 131451 131525 +74
==========================================
+ Hits 48575 48632 +57
- Misses 78655 78666 +11
- Partials 4221 4227 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cherry-pick the following change to populate oauth metadata once on initialization using Sync.Do ca04314 Tested locally using uctl-admin and fetched projects calling into admin which exercises the auth flow https://buildkite.com/unionai/org-staging-sync/builds/3541 Rollout to all canary and then prod tenants - [x] To be upstreamed to OSS *TODO: Link Linear issue(s) using [magic words](https://linear.app/docs/github#magic-words). `fixes` will move to merged status, while `ref` will only link the PR.* * [ ] Added tests * [ ] Ran a deploy dry run and shared the terraform plan * [ ] Added logging and metrics * [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list) * [ ] Updated documentation Signed-off-by: pmahindrakar-oss <[email protected]>
…token (#330) * Add logs for token * add logs * Fixing the validity check logic for token * nit * nit * Adding in memory token source provider * nit * changed Valid method to log and ignore parseDateClaim error * nit * Fix unit tests * lint * fix unit tests Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss
force-pushed
the
union/upstream-d6b17dc0c1addc68c593fc79d4c53a9f081a6387
branch
from
185248b
to
29e31d3
Compare
andrewwdye
approved these changes
Nov 14, 2024
pmahindrakar-oss
deleted the
union/upstream-d6b17dc0c1addc68c593fc79d4c53a9f081a6387
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
With changes in this PR #5407 only one request was allowed to fetch auth token from the provider if multiple parallel requests came in.
There were two calls made to MaterializeCredentials, the purpose of which was to fetch the token from cache or get new token and add them to communication channel.
Expectation of fetching new token on the first MaterializeCredentials was unexpected as this was only expected to fetch the token from cache if available and add it to the communication channel.
The new change fixes this issue so that the first call is always fetching from in memory cache by introducing a new InMemoryTokenSourceProvider.
Also the Oauth token library uses relative time using the expires_in field for validity checks which doesn't work when we are returning cache tokens as it incorrectly gives an invalid expiry and client tries to use this invalid token
Modified the logic to define custom validity function which parses the exp claim and checks for validity. Also added this to baseorchestrator so that all the other auth mechanisms use the same Validity check
How was this patch tested?
This has been tested internally on Union cluster
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link