Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsonpb AllowUnknownFields everywhere #5521

Merged
merged 3 commits into from
Jul 4, 2024

make lint-fix

a4aec9c
Select commit
Loading
Failed to load commit list.
Merged

Use jsonpb AllowUnknownFields everywhere #5521

make lint-fix
a4aec9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 28, 2024 in 0s

61.05% (+0.05%) compared to ce5eb03

View this Pull Request on Codecov

61.05% (+0.05%) compared to ce5eb03

Details

Codecov Report

Attention: Patch coverage is 58.82353% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.05%. Comparing base (ce5eb03) to head (a4aec9c).
Report is 3 commits behind head on master.

Files Patch % Lines
...epropeller/pkg/apis/flyteworkflow/v1alpha1/gate.go 0.00% 6 Missing ⚠️
...ller/pkg/apis/flyteworkflow/v1alpha1/identifier.go 0.00% 5 Missing ⚠️
...propeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go 50.00% 4 Missing ⚠️
flytectl/cmd/get/node_execution.go 50.00% 2 Missing ⚠️
flytestdlib/utils/marshal_utils.go 84.61% 0 Missing and 2 partials ⚠️
...propeller/pkg/apis/flyteworkflow/v1alpha1/tasks.go 50.00% 1 Missing ⚠️
...peller/pkg/apis/flyteworkflow/v1alpha1/workflow.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5521      +/-   ##
==========================================
+ Coverage   60.99%   61.05%   +0.05%     
==========================================
  Files         794      794              
  Lines       51475    51433      -42     
==========================================
+ Hits        31397    31402       +5     
+ Misses      17186    17146      -40     
+ Partials     2892     2885       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.