Use jsonpb AllowUnknownFields everywhere #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5521 +/- ##
==========================================
+ Coverage 60.99% 61.05% +0.05%
==========================================
Files 794 794
Lines 51475 51433 -42
==========================================
+ Hits 31397 31402 +5
+ Misses 17186 17146 -40
+ Partials 2892 2885 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
force-pushed
the
andrew/use-jsonpb-allowunknownfields-everywhere
branch
from
a854a08
to
c996dcb
Compare
squiishyy
previously approved these changes
Jun 27, 2024
Signed-off-by: Andrew Dye <[email protected]>
Signed-off-by: Andrew Dye <[email protected]>
eapolinario
approved these changes
Jul 4, 2024
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
* Use jsonpb AllowUnknownFields everywhere Signed-off-by: Andrew Dye <[email protected]> * Missing return Signed-off-by: Andrew Dye <[email protected]> * make lint-fix Signed-off-by: Andrew Dye <[email protected]> --------- Signed-off-by: Andrew Dye <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
By default
jsonpb.Unmarshal(),jsonpb.UnmarshalString, andjsonpb.Unmarshaler{}setsAllowUnknownFieldstofalse, which means that unmarshaling a proto message with a newly added field will fail here.What changes were proposed in this pull request?
This change updates all use of
jsonpb.Unmarshal*to use theflytestlib/utils.Unmarshal*abstractions, which setAllowUnknownFieldstotrue.There is some risk that this break existing assumptions about new field handling, but since protobuf silently drops fields, it seems reasonable to default to this behavior across the flyte codebase.
How was this patch tested?
Unittests
Setup process
Screenshots
Check all the applicable boxes