Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flyteadmin server config option to enable grpc histogram metrics #4231

Merged
merged 4 commits into from
Oct 16, 2023

logs

e1f8997
Select commit
Loading
Failed to load commit list.
Merged

Add flyteadmin server config option to enable grpc histogram metrics #4231

logs
e1f8997
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 16, 2023 in 0s

59.05% (-0.47%) compared to 2edc3bd

View this Pull Request on Codecov

59.05% (-0.47%) compared to 2edc3bd

Details

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2edc3bd) 59.52% compared to head (e1f8997) 59.05%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4231      +/-   ##
==========================================
- Coverage   59.52%   59.05%   -0.47%     
==========================================
  Files         639      621      -18     
  Lines       54611    53092    -1519     
==========================================
- Hits        32506    31355    -1151     
+ Misses      19543    19238     -305     
+ Partials     2562     2499      -63     
Files Coverage Δ
flyteadmin/pkg/config/config.go 18.75% <ø> (ø)
flyteadmin/pkg/config/serverconfig_flags.go 61.11% <100.00%> (+0.73%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.