Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flyteadmin server config option to enable grpc histogram metrics #4231

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

katrogan
Copy link
Contributor

Tracking issue

#4214

Describe your changes

Enables grpc metrics histograms: https://github.com/grpc-ecosystem/go-grpc-prometheus#histograms
which are high cardinality and are therefore made disabled by default.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan changed the title Grpc histogram Add flyteadmin server config option to enable grpc histogram metrics Oct 14, 2023
Signed-off-by: Katrina Rogan <[email protected]>
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2edc3bd) 59.52% compared to head (8c6e42a) 59.37%.
Report is 2 commits behind head on master.

❗ Current head 8c6e42a differs from pull request most recent head e1f8997. Consider uploading reports for the commit e1f8997 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4231      +/-   ##
==========================================
- Coverage   59.52%   59.37%   -0.15%     
==========================================
  Files         639      552      -87     
  Lines       54611    39905   -14706     
==========================================
- Hits        32506    23694    -8812     
+ Misses      19543    13878    -5665     
+ Partials     2562     2333     -229     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteadmin/pkg/config/config.go 20.00% <ø> (+1.25%) ⬆️
flyteadmin/pkg/config/serverconfig_flags.go 63.46% <100.00%> (+3.08%) ⬆️

... and 574 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan requested a review from eapolinario October 16, 2023 22:29
@katrogan
Copy link
Contributor Author

PTAL @pingsutw @eapolinario

@katrogan katrogan merged commit a114769 into master Oct 16, 2023
35 of 36 checks passed
@katrogan katrogan deleted the grpc-histogram branch October 16, 2023 23:43
squiishyy pushed a commit to squiishyy/flyte that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants