Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from flyteplugins - Override Ray config with fields for namespace, service account, pod resources #4136

Conversation

eapolinario
Copy link
Contributor

As per our conversation with the Union AI, we are making the following changes to the Ray plugin to enable more parameters to be configurable on the user side using flytekit SDK.

see: flyteorg/flyteidl#429

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • [x ] Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

guozhen la and others added 4 commits August 11, 2023 04:03
Signed-off-by: guozhen la <[email protected]>
Signed-off-by: guozhen la <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d9586b0) 58.98% compared to head (b734395) 59.54%.

❗ Current head b734395 differs from pull request most recent head b574772. Consider uploading reports for the commit b574772 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4136      +/-   ##
==========================================
+ Coverage   58.98%   59.54%   +0.55%     
==========================================
  Files         619      216     -403     
  Lines       52804    15938   -36866     
==========================================
- Hits        31146     9490   -21656     
+ Misses      19174     5473   -13701     
+ Partials     2484      975    -1509     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 600 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant