Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Ray config with fields for namespace, service account, pod resources #4170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guozhen-la
Copy link

Recreates PR that was moved in the monorepo
see #4136

As per our conversation with the Union AI, we are making the following changes to the Ray plugin to enable more parameters to be configurable on the user side using flytekit SDK.

see: flyteorg/flyteidl#429

Tracking issue

Describe your changes

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

@welcome
Copy link

welcome bot commented Oct 4, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Signed-off-by: guozhen la <[email protected]>
@guozhen-la guozhen-la force-pushed the add-ray-head-worker-resources branch from e3888f3 to 3cbc269 Compare October 4, 2023 18:29
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.54%. Comparing base (a9f5d24) to head (14d8d12).
Report is 956 commits behind head on master.

Current head 14d8d12 differs from pull request most recent head 3cbc269

Please upload reports for the commit 3cbc269 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4170      +/-   ##
==========================================
+ Coverage   54.59%   59.54%   +4.94%     
==========================================
  Files         178      216      +38     
  Lines       16038    15938     -100     
==========================================
+ Hits         8756     9490     +734     
+ Misses       6568     5473    -1095     
- Partials      714      975     +261     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant