Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use git lfs for png files #218

Merged
merged 3 commits into from
Jan 5, 2025
Merged

chore: use git lfs for png files #218

merged 3 commits into from
Jan 5, 2025

Conversation

fluxxcode
Copy link
Owner

Set up git lfs to track PNG files to improve repository performance.

Closes #212

Copy link
Contributor

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
do the images still work in the readme?

@fluxxcode
Copy link
Owner Author

Nope, at least not on this branch. But I'm a bit confused in general, git lfs should replace the PNG files with plain text files that contain the pointer to the image. In this case, however, the PNG files are still much too large and even have the PNG signature at the beginning. Git lfs changed something in the files, but it didn't seem to be the right thing. That's why the PR is still open here. I didn't have enough time to debug it.

@crumblingstatue
Copy link
Contributor

An alternative is to just use Github CDN for storing the images.
I have a screenshot pseudo-issue in some of my projects for example.
You can then just copy the link to the images and put them into your readme or whatever.

@fluxxcode
Copy link
Owner Author

fluxxcode commented Dec 17, 2024

Thanks for the idea! Is it possible versioning (and tagging) the images with the repo using Github CDN? Have never used it

@crumblingstatue
Copy link
Contributor

Thanks for the idea! Is it possible versioning (and tagging) the images with the repo using Github CDN? Have never used it

No, but you don't really need to do that, since you only need to commit the image links to git. As long as you keep the old images on GitHub, the links will remain valid.

@fluxxcode fluxxcode merged commit 9d96ee9 into develop Jan 5, 2025
5 checks passed
@fluxxcode
Copy link
Owner Author

Git LFS seems to be working now. @bircni I have adopted the documentation that you sent me on discord for the readme. Thanks for that!

@bircni
Copy link
Contributor

bircni commented Jan 5, 2025

yey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use git-lfs for images
3 participants