[Desktop] Remove contextual menu when selecting all #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 84.56% 84.68% +0.11%
==========================================
Files 60 60
Lines 9620 9635 +15
==========================================
+ Hits 8135 8159 +24
+ Misses 1485 1476 -9 ☔ View full report in Codecov by Sentry. |
amantoux
force-pushed
the
fix/ramanent_contextual_menu
branch
from
93f60bf to
2fb7582
Compare
amantoux
force-pushed
the
fix/ramanent_contextual_menu
branch
from
2fb7582 to
4d46960
Compare
Amir-P
reviewed
Dec 8, 2023
| case TargetPlatform.fuchsia: | ||
| case TargetPlatform.linux: | ||
| case TargetPlatform.windows: | ||
| bringIntoView(textEditingValue.selection.extent); |
There was a problem hiding this comment.
Is there any reason we don't call bringIntoView on iOS and macOS? @amantoux
There was a problem hiding this comment.
It's how it is implemented in Flutter
Didn't dig further but it is the observed behavior on TextField on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186