Fix persistent contextual menu when selecting all on desktop

fleather-editor · Dec 8, 2023 · 2fb7582 · 2fb7582
1 parent 416244c
commit 2fb7582
Show file tree

Hide file tree

Showing 2 changed files with 74 additions and 1 deletion.
diff --git a/packages/fleather/lib/src/widgets/editor.dart b/packages/fleather/lib/src/widgets/editor.dart
@@ -910,8 +910,35 @@ class RawEditorState extends EditorState
       ),
       cause,
     );
+    userUpdateTextEditingValue(
+      textEditingValue.copyWith(
+        selection: TextSelection(
+            baseOffset: 0, extentOffset: textEditingValue.text.length),
+      ),
+      cause,
+    );
+
     if (cause == SelectionChangedCause.toolbar) {
-      bringIntoView(textEditingValue.selection.extent);
+      switch (defaultTargetPlatform) {
+        case TargetPlatform.android:
+        case TargetPlatform.iOS:
+        case TargetPlatform.fuchsia:
+          break;
+        case TargetPlatform.macOS:
+        case TargetPlatform.linux:
+        case TargetPlatform.windows:
+          hideToolbar();
+      }
+      switch (defaultTargetPlatform) {
+        case TargetPlatform.android:
+        case TargetPlatform.fuchsia:
+        case TargetPlatform.linux:
+        case TargetPlatform.windows:
+          bringIntoView(textEditingValue.selection.extent);
+        case TargetPlatform.macOS:
+        case TargetPlatform.iOS:
+          break;
+      }
     }
   }
 

diff --git a/packages/fleather/test/widgets/editor_test.dart b/packages/fleather/test/widgets/editor_test.dart
@@ -447,6 +447,52 @@ void main() {
             const TypeMatcher<DesktopTextSelectionControls>());
       }, [TargetPlatform.linux]);
 
+      testWidgetsWithPlatform('selectAll for macOS', (tester) async {
+        final document = ParchmentDocument.fromJson([
+          {'insert': 'Test\nAnother line\n'}
+        ]);
+        final editor = EditorSandBox(tester: tester, document: document);
+        await editor.pump();
+        await tester.tapAt(
+            tester.getTopLeft(find.byType(FleatherEditor)) + const Offset(1, 1),
+            buttons: kSecondaryMouseButton);
+        await tester.pump();
+        expect(
+            find.byType(CupertinoDesktopTextSelectionToolbar), findsOneWidget);
+        await tester.tap(find.text('Select All')); // Select All in macOS
+        await tester.pump();
+        expect(
+            editor.selection,
+            const TextSelection(
+                baseOffset: 0,
+                extentOffset: 17,
+                affinity: TextAffinity.upstream));
+        expect(find.byType(CupertinoDesktopTextSelectionToolbar), findsNothing);
+      }, [TargetPlatform.macOS]);
+
+      testWidgetsWithPlatform('selectAll for Windows/Linux', (tester) async {
+        final document = ParchmentDocument.fromJson([
+          {'insert': 'Test\nAnother line\n'}
+        ]);
+        final editor = EditorSandBox(tester: tester, document: document);
+        await editor.pump();
+        await tester.tapAt(
+            tester.getTopLeft(find.byType(FleatherEditor)) + const Offset(1, 1),
+            buttons: kSecondaryMouseButton);
+        await tester.pump();
+        expect(find.byType(DesktopTextSelectionToolbar), findsOneWidget);
+        await tester
+            .tap(find.text('Select all')); // Select all in other than macOS
+        await tester.pump();
+        expect(
+            editor.selection,
+            const TextSelection(
+                baseOffset: 0,
+                extentOffset: 17,
+                affinity: TextAffinity.upstream));
+        expect(find.byType(DesktopTextSelectionToolbar), findsNothing);
+      }, [TargetPlatform.linux, TargetPlatform.windows]);
+
       testWidgetsWithPlatform(
           'Triple tap selects paragraph on platforms other than Linux',
           (tester) async {