Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support of new identity: code, tests and CI #252

Closed
wants to merge 7 commits into from
Closed

support of new identity: code, tests and CI #252

wants to merge 7 commits into from

Conversation

alexradzin
Copy link
Collaborator

No description provided.

stepansergeevitch
stepansergeevitch approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming no changes were made and the review was done in previous PR: #238

@alexradzin alexradzin force-pushed the feature/FIR-21173-new-identity-support branch 2 times, most recently from 0c483f0 to 68e6f48 Compare August 3, 2023 13:33
@alexradzin alexradzin force-pushed the feature/FIR-21173-new-identity-support branch 2 times, most recently from 4da89e9 to 1b9d0ab Compare August 16, 2023 17:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

85.9% 85.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@alexradzin alexradzin mentioned this pull request Sep 4, 2023
Closed
@alexradzin alexradzin force-pushed the feature/FIR-21173-new-identity-support branch from 8c293a5 to 8dd589a Compare October 5, 2023 14:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

85.9% 85.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stepansergeevitch
Create CODEOWNERS
4c1108b 
Create CODEOWNERS file
@alexradzin alexradzin requested a review from a team as a code owner October 11, 2023 14:18
@alexradzin
Copy link
Collaborator Author

Other branch that combines both implementations was created from here, developed, tested and merged to master, so this PR can be closed as obsolete

@alexradzin alexradzin closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepansergeevitch stepansergeevitch stepansergeevitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexradzin @stepansergeevitch @aymeric-dispa