Feature/fir 21173 add identity support

[alexradzin]

updated minimal implementation of the new identity

[stepansergeevitch]

Generally LGTM, left one question. I would also ask to wait for an approval from Petro

[stepansergeevitch]

Just a question, should't it also be throws FireboltException, since we do throw new FireboltException(...)?

[alexradzin]

No. Generally the interfaces should use general terms. Prefer interface to class, prefer interface/class higher in hierarchy than specific one. This is the basics of the OOD.
Specifically here. FireboltException extends SQLException and therefore can be thrown from any function that is declared as throws SQLException. The opposite is incorrect. If your function is declared as throws FireboltException it cannot throw SQLException. This is the reason that there many places in code that look like the following:

void someFunction() throws FireboltException {
    try {
        // some code that throws SQLException
    } catch (SQLException e) {
        throw new FireboltException(e)
    }
}

This try/catch is absolutely redundant. Just declare that function throws SQLException.

[stepansergeevitch]

Ok, makes sense

[ptiurin]

LGTM, thanks for the change.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

85.8% Coverage
0.0% Duplication

[alexradzin]

This historical PR has been replaced by #252