-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Dependencies property support for Current Working Directory #1196
Merged
DamianReeves
merged 7 commits into
finos:main
from
reebayroo:local-reference-cwd-support
Oct 7, 2024
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
484b315
ignore all .DS_Store
reebayroo 1ef6d73
Support to Current Working Directory
reebayroo de6cc65
refactoring and clean up
reebayroo d7be1ae
Fetch cwd files before project dir files
reebayroo 779201e
attempt to fix vulnerability
reebayroo a28c964
attempt to fix vulnerability
reebayroo 42d85fa
putting package-lock back
reebayroo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,17 +35,17 @@ export const FileUrl = z.string().trim().url().transform((val, ctx) => { | |
}); | ||
|
||
type LocalFileRef = { | ||
projectDir: string, | ||
baseDir: string, | ||
original: string, | ||
fullPath: string, | ||
url?: URL, | ||
|
||
} | ||
|
||
export const LocalFile = z.object({ | ||
projectDir: z.string(), | ||
baseDir: z.string(), | ||
sanitized: z.string(), | ||
}).transform(val => <LocalFileRef>{projectDir:val.projectDir, original: val.sanitized, fullPath: path.resolve(val.projectDir, val.sanitized ) }) | ||
}).transform(val => <LocalFileRef>{ baseDir: val.baseDir, original: val.sanitized, fullPath: path.resolve(val.baseDir, val.sanitized) }) | ||
.transform(ref => <LocalFileRef>({ ...ref, url: new URL(`file://${ref.fullPath}`) })) | ||
.refine((ref: LocalFileRef) => fs.existsSync(ref.fullPath), | ||
(ref: LocalFileRef) => { | ||
|
@@ -87,7 +87,7 @@ const IncludeProvided = z.object({ | |
|
||
const LocalDependencyProvided = z.object({ | ||
eventKind: z.literal('LocalDependencyProvided'), | ||
payload: z.string() | ||
payload: z.string() | ||
}) | ||
|
||
const DependencyProvided = z.object({ | ||
|
@@ -148,7 +148,7 @@ export async function loadAllDependencies(config: DependencyConfig) { | |
}); | ||
} | ||
|
||
const load = (config: DependencyConfig) => function(event: DependencyEvent) { | ||
const load = (config: DependencyConfig) => function (event: DependencyEvent) { | ||
|
||
//TODO: Clear this up | ||
let source: "dependencies" | "localDependencies" | "includes"; | ||
|
@@ -173,7 +173,7 @@ const load = (config: DependencyConfig) => function(event: DependencyEvent) { | |
} | ||
} | ||
} | ||
const loadDependenciesFromString = (config: DependencyConfig) => function(input: string, source: string) { | ||
const loadDependenciesFromString = (config: DependencyConfig) => function (input: string, source: string) { | ||
const doWork = async () => { | ||
let sanitized = input.trim(); | ||
let { success, data } = DataUrl.safeParse(sanitized); | ||
|
@@ -195,10 +195,19 @@ const loadDependenciesFromString = (config: DependencyConfig) => function(input: | |
console.info("Loading url", urlData); | ||
return fetchUriToJson(urlData); | ||
} | ||
let { success: localFileSuccess, data: localUrlData } = LocalFile.safeParse({projectDir : config.projectDir, sanitized}); | ||
|
||
let { success: localFileCWDSuccess, data: localUrlCWDData } = LocalFile.safeParse({ baseDir: process.cwd(), sanitized }); | ||
if (localFileCWDSuccess && localUrlCWDData !== undefined) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using cwd first as baseDir |
||
|
||
console.info("Loading local file url from current working directory ", localUrlCWDData); | ||
return fetchUriToJson(localUrlCWDData); | ||
|
||
} | ||
|
||
let { success: localFileSuccess, data: localUrlData } = LocalFile.safeParse({ baseDir: config.projectDir, sanitized }); | ||
if (localFileSuccess && localUrlData !== undefined) { | ||
|
||
console.info("Loading local file url", localUrlData); | ||
console.info("Loading local file url from morphir.json directory", localUrlData); | ||
return fetchUriToJson(localUrlData); | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renaming projectDir to baseDir for consistency