Local Dependencies property support for Current Working Directory #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reebayroo
commented
Oct 6, 2024
| @@ -18,7 +18,7 @@ describe("the dependencies module", () => { | |||
| test("should fail if can't find the file.", () => { | |||
| try { | |||
| dep.LocalFile.parse({ | |||
| projectDir: __dirname, | |||
| baseDir: __dirname, | |||
There was a problem hiding this comment.
renaming projectDir to baseDir for consistency
reebayroo
commented
Oct 6, 2024
| let { success: localFileSuccess, data: localUrlData } = LocalFile.safeParse({projectDir : config.projectDir, sanitized}); | ||
|
|
||
| let { success: localFileCWDSuccess, data: localUrlCWDData } = LocalFile.safeParse({ baseDir: process.cwd(), sanitized }); | ||
| if (localFileCWDSuccess && localUrlCWDData !== undefined) { |
There was a problem hiding this comment.
Using cwd first as baseDir
reebayroo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update (version 2.90.1) has changed the behavior of
morphir.json'slocalDependencyproperty.On that version local references were using the
-p, --project-dirargument from themakecommand as a base directory to look up that dependency.This PR remediates this by additionally looking up for the reference from the current working folder: The folder that
morphir-elmwas called from.Terms