Skip to content

Commit

Permalink
Revert "add missing extensions in legend extension collections (#2458)…
Browse files Browse the repository at this point in the history 
…" (#2465)

This reverts commit 9cb5998.
  • Loading branch information
@MauricioUyaguari
MauricioUyaguari authored Nov 17, 2023
1 parent 9cb5998 commit b3837ac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 55 deletions.
18 changes: 0 additions & 18 deletions legend-engine-config/legend-engine-extensions-collection-generation/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,6 @@
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-protocol-pure</artifactId>
</dependency>
<dependency>
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-testable</artifactId>
</dependency>
<dependency>
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-configuration</artifactId>
</dependency>

<dependency>
<groupId>org.finos.legend.engine</groupId>
Expand All @@ -170,11 +162,6 @@
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-external-shared-format-model</artifactId>
</dependency>
<dependency>
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-test-runner-mapping</artifactId>
<scope>runtime</scope>
</dependency>
<!-- ENGINE -->


Expand Down Expand Up @@ -419,11 +406,6 @@
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-language-pure-dsl-service-pure</artifactId>
</dependency>
<dependency>
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-test-runner-service</artifactId>
<scope>runtime</scope>
</dependency>
<!-- Service -->

<!-- Elastic Store -->
Expand Down
41 changes: 4 additions & 37 deletions ...rc/test/java/org/finos/legend/engine/extensions/collection/generation/TestExtensions.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,7 @@
import org.finos.legend.engine.language.sql.grammar.integration.SQLGrammarParserExtension;
import org.finos.legend.engine.language.sql.grammar.integration.SQLPureGrammarComposerExtension;
import org.finos.legend.engine.language.stores.elasticsearch.v7.from.ElasticsearchGrammarParserExtension;
import org.finos.legend.engine.plan.generation.extension.LegendPlanGeneratorExtension;
import org.finos.legend.engine.plan.generation.extension.PlanGeneratorExtension;
import org.finos.legend.engine.protocol.bigqueryFunction.metamodel.BigQueryFunctionProtocolExtension;
import org.finos.legend.engine.testable.extension.TestableRunnerExtension;
import org.finos.legend.engine.testable.mapping.extension.MappingTestableRunnerExtension;
import org.finos.legend.engine.testable.persistence.extension.PersistenceTestableRunnerExtension;
import org.finos.legend.engine.testable.service.extension.ServiceTestableRunnerExtension;
import org.finos.legend.pure.code.core.ElasticsearchPureCoreExtension;
import org.finos.legend.engine.language.stores.elasticsearch.v7.to.ElasticsearchGrammarComposerExtension;
import org.finos.legend.engine.protocol.pure.v1.extension.PureProtocolExtension;
Expand Down Expand Up @@ -144,7 +138,7 @@ public void testExpectedCompilerExtensionsArePresent()
@Test
public void testPlanGeneratorExtensionArePresent()
{
assertHasExtensions(getExpectedPureExtensions(), PureCoreExtension.class);
assertHasExtensions(getExpectedPlanGeneratorExtensions(), PureCoreExtension.class);
}

@Test
Expand All @@ -171,18 +165,6 @@ public void testExpectedEntitlementServiceExtensionsArePresent()
assertHasExtensions(EntitlementServiceExtensionLoader.extensions(), getExpectedEntitlementServiceExtensions(), EntitlementServiceExtension.class);
}

@Test
public void testExpectedPlanGeneratorExtension()
{
assertHasExtensions(getExpectedPlanGeneratorExtensions(), PlanGeneratorExtension.class);
}

@Test
public void testExpectedTestableRunnerExtension()
{
assertHasExtensions(getExpectedTestableExtensions(), TestableRunnerExtension.class);
}

@Test
public void testCodeRepositories()
{
Expand Down Expand Up @@ -317,22 +299,6 @@ protected Iterable<? extends Class<? extends PureProtocolExtension>> getExpected
;
}

protected Iterable<? extends Class<? extends TestableRunnerExtension>> getExpectedTestableExtensions()
{
// DO NOT DELETE ITEMS FROM THIS LIST (except when replacing them with something equivalent)
return Lists.mutable.<Class<? extends TestableRunnerExtension>>empty()
.with(ServiceTestableRunnerExtension.class)
.with(MappingTestableRunnerExtension.class)
.with(PersistenceTestableRunnerExtension.class);
}

protected Iterable<? extends Class<? extends PlanGeneratorExtension>> getExpectedPlanGeneratorExtensions()
{
return Lists.mutable.<Class<? extends PlanGeneratorExtension>>empty()
.with(LegendPlanGeneratorExtension.class);

}

protected Iterable<? extends Class<? extends GenerationExtension>> getExpectedGenerationExtensions()
{
// DO NOT DELETE ITEMS FROM THIS LIST (except when replacing them with something equivalent)
Expand Down Expand Up @@ -443,7 +409,7 @@ protected Iterable<? extends Class<? extends CompilerExtension>> getExpectedComp
;
}

protected Iterable<? extends Class<? extends PureCoreExtension>> getExpectedPureExtensions()
protected Iterable<? extends Class<? extends PureCoreExtension>> getExpectedPlanGeneratorExtensions()
{
// DO NOT DELETE ITEMS FROM THIS LIST (except when replacing them with something equivalent)
return Lists.mutable.<Class<? extends PureCoreExtension>>empty()
Expand All @@ -463,7 +429,8 @@ protected Iterable<? extends Class<? extends PureCoreExtension>> getExpectedPure
.with(XMLJavaBindingPureCoreExtension.class)
.with(ServicePureCoreExtension.class)
.with(RelationalJavaBindingPureCoreExtension.class)
.with(ArrowPureCoreExtension.class);
.with(ArrowPureCoreExtension.class)
;
}

protected Iterable<? extends Class<? extends ExternalFormatExtension<?>>> getExpectedExternalFormatExtensions()
Expand Down

0 comments on commit b3837ac

Please sign in to comment.