add missing extensions in legend extension collections (#2458)

finos · Nov 16, 2023 · 9cb5998 · 9cb5998
1 parent 0060453
commit 9cb5998
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 4 deletions.
diff --git a/legend-engine-config/legend-engine-extensions-collection-generation/pom.xml b/legend-engine-config/legend-engine-extensions-collection-generation/pom.xml
@@ -140,6 +140,14 @@
             <groupId>org.finos.legend.engine</groupId>
             <artifactId>legend-engine-protocol-pure</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.finos.legend.engine</groupId>
+            <artifactId>legend-engine-testable</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.finos.legend.engine</groupId>
+            <artifactId>legend-engine-configuration</artifactId>
+        </dependency>
 
         <dependency>
             <groupId>org.finos.legend.engine</groupId>
@@ -162,6 +170,11 @@
             <groupId>org.finos.legend.engine</groupId>
             <artifactId>legend-engine-external-shared-format-model</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.finos.legend.engine</groupId>
+            <artifactId>legend-engine-test-runner-mapping</artifactId>
+            <scope>runtime</scope>
+        </dependency>
         <!-- ENGINE -->
 
 
@@ -406,6 +419,11 @@
             <groupId>org.finos.legend.engine</groupId>
             <artifactId>legend-engine-language-pure-dsl-service-pure</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.finos.legend.engine</groupId>
+            <artifactId>legend-engine-test-runner-service</artifactId>
+            <scope>runtime</scope>
+        </dependency>
         <!-- Service -->
 
         <!-- Elastic Store -->

diff --git a/...rc/test/java/org/finos/legend/engine/extensions/collection/generation/TestExtensions.java b/...rc/test/java/org/finos/legend/engine/extensions/collection/generation/TestExtensions.java
@@ -83,7 +83,13 @@
 import org.finos.legend.engine.language.sql.grammar.integration.SQLGrammarParserExtension;
 import org.finos.legend.engine.language.sql.grammar.integration.SQLPureGrammarComposerExtension;
 import org.finos.legend.engine.language.stores.elasticsearch.v7.from.ElasticsearchGrammarParserExtension;
+import org.finos.legend.engine.plan.generation.extension.LegendPlanGeneratorExtension;
+import org.finos.legend.engine.plan.generation.extension.PlanGeneratorExtension;
 import org.finos.legend.engine.protocol.bigqueryFunction.metamodel.BigQueryFunctionProtocolExtension;
+import org.finos.legend.engine.testable.extension.TestableRunnerExtension;
+import org.finos.legend.engine.testable.mapping.extension.MappingTestableRunnerExtension;
+import org.finos.legend.engine.testable.persistence.extension.PersistenceTestableRunnerExtension;
+import org.finos.legend.engine.testable.service.extension.ServiceTestableRunnerExtension;
 import org.finos.legend.pure.code.core.ElasticsearchPureCoreExtension;
 import org.finos.legend.engine.language.stores.elasticsearch.v7.to.ElasticsearchGrammarComposerExtension;
 import org.finos.legend.engine.protocol.pure.v1.extension.PureProtocolExtension;
@@ -138,7 +144,7 @@ public void testExpectedCompilerExtensionsArePresent()
     @Test
     public void testPlanGeneratorExtensionArePresent()
     {
-        assertHasExtensions(getExpectedPlanGeneratorExtensions(), PureCoreExtension.class);
+        assertHasExtensions(getExpectedPureExtensions(), PureCoreExtension.class);
     }
 
     @Test
@@ -165,6 +171,18 @@ public void testExpectedEntitlementServiceExtensionsArePresent()
         assertHasExtensions(EntitlementServiceExtensionLoader.extensions(), getExpectedEntitlementServiceExtensions(), EntitlementServiceExtension.class);
     }
 
+    @Test
+    public void testExpectedPlanGeneratorExtension()
+    {
+        assertHasExtensions(getExpectedPlanGeneratorExtensions(), PlanGeneratorExtension.class);
+    }
+
+    @Test
+    public void testExpectedTestableRunnerExtension()
+    {
+        assertHasExtensions(getExpectedTestableExtensions(), TestableRunnerExtension.class);
+    }
+
     @Test
     public void testCodeRepositories()
     {
@@ -299,6 +317,22 @@ protected Iterable<? extends Class<? extends PureProtocolExtension>> getExpected
                 ;
     }
 
+    protected Iterable<? extends Class<? extends TestableRunnerExtension>> getExpectedTestableExtensions()
+    {
+        // DO NOT DELETE ITEMS FROM THIS LIST (except when replacing them with something equivalent)
+        return Lists.mutable.<Class<? extends TestableRunnerExtension>>empty()
+                .with(ServiceTestableRunnerExtension.class)
+                .with(MappingTestableRunnerExtension.class)
+                .with(PersistenceTestableRunnerExtension.class);
+    }
+
+    protected Iterable<? extends Class<? extends PlanGeneratorExtension>> getExpectedPlanGeneratorExtensions()
+    {
+        return Lists.mutable.<Class<? extends PlanGeneratorExtension>>empty()
+                .with(LegendPlanGeneratorExtension.class);
+
+    }
+
     protected Iterable<? extends Class<? extends GenerationExtension>> getExpectedGenerationExtensions()
     {
         // DO NOT DELETE ITEMS FROM THIS LIST (except when replacing them with something equivalent)
@@ -409,7 +443,7 @@ protected Iterable<? extends Class<? extends CompilerExtension>> getExpectedComp
                 ;
     }
 
-    protected Iterable<? extends Class<? extends PureCoreExtension>> getExpectedPlanGeneratorExtensions()
+    protected Iterable<? extends Class<? extends PureCoreExtension>> getExpectedPureExtensions()
     {
         // DO NOT DELETE ITEMS FROM THIS LIST (except when replacing them with something equivalent)
         return Lists.mutable.<Class<? extends PureCoreExtension>>empty()
@@ -429,8 +463,7 @@ protected Iterable<? extends Class<? extends PureCoreExtension>> getExpectedPlan
                 .with(XMLJavaBindingPureCoreExtension.class)
                 .with(ServicePureCoreExtension.class)
                 .with(RelationalJavaBindingPureCoreExtension.class)
-                .with(ArrowPureCoreExtension.class)
-                ;
+                .with(ArrowPureCoreExtension.class);
     }
 
     protected Iterable<? extends Class<? extends ExternalFormatExtension<?>>> getExpectedExternalFormatExtensions()