Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on new rubies #50

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Test on new rubies #50

merged 1 commit into from
Jan 10, 2024

Conversation

benlangfeld
Copy link
Contributor

@benlangfeld benlangfeld commented Jan 9, 2024 •
edited
Loading

I'm expecting this to fail something like this:

/Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require': cannot load such file -- racc/parser.rb (LoadError)
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/tomlrb-2.0.3/lib/tomlrb/generated_parser.rb:7:in `<top (required)>'
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/tomlrb-2.0.3/lib/tomlrb/parser.rb:1:in `<top (required)>'
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /Users/blangfeld/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/tomlrb-2.0.3/lib/tomlrb.rb:9:in `<top (required)>'

@benlangfeld benlangfeld mentioned this pull request Jan 9, 2024
Closed
benlangfeld added a commit to powerhome/oss-guide that referenced this pull request Jan 9, 2024
@benlangfeld
Compatibility with Ruby 3.3
c7685a7 
We expect to be able to revert this change once the upstream issue is resolved.

See pivotal/LicenseFinder#1013 and fbernier/tomlrb#50.
@benlangfeld benlangfeld mentioned this pull request Jan 9, 2024
Merged
benlangfeld added a commit to powerhome/oss-guide that referenced this pull request Jan 9, 2024
@benlangfeld
Compatibility with Ruby 3.3 (#15)
480cb51 
We expect to be able to revert this change once the upstream issue is resolved.

See pivotal/LicenseFinder#1013 and fbernier/tomlrb#50.
@fbernier
Copy link
Owner

It did not

@benlangfeld
Copy link
Contributor Author

Can we merge this anyway?

@fbernier fbernier merged commit a1eaa06 into fbernier:master Jan 10, 2024
22 checks passed
@benlangfeld benlangfeld deleted the patch-1 branch January 10, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlangfeld @fbernier