Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves: ImportError cannot import name FixedNoiseGP from botorch.models.gp_regression #179

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Resolves: ImportError cannot import name FixedNoiseGP from botorch.models.gp_regression #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3b9231
Use SingleTaskGP instead of FixedNoiseGP as recommended in the Deprec…
flo-schu Nov 18, 2024
b590411
remove ax-platform version pin
ronald-jaepel Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CADETProcess/optimization/axAdapater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from ax.utils.common.result import Err, Ok
from ax.service.utils.report_utils import exp_to_df
from botorch.utils.sampling import manual_seed
from botorch.models.gp_regression import FixedNoiseGP
from botorch.models.gp_regression import SingleTaskGP
from botorch.acquisition.analytic import (
LogExpectedImprovement
)
Expand Down Expand Up @@ -521,7 +521,7 @@ class BotorchModular(SingleObjectiveAxInterface):
surrogate_model: Model class
"""
acquisition_fn = Typed(ty=type, default=LogExpectedImprovement)
surrogate_model = Typed(ty=type, default=FixedNoiseGP)
surrogate_model = Typed(ty=type, default=SingleTaskGP)

_specific_options = [
'acquisition_fn', 'surrogate_model'
Expand Down Expand Up @@ -552,7 +552,7 @@ class NEHVI(MultiObjectiveAxInterface):
supports_single_objective = False

def __repr__(self):
smn = 'FixedNoiseGP'
smn = 'SingleTaskGP'
afn = 'NEHVI'

return f'{smn}+{afn}'
Expand All @@ -578,7 +578,7 @@ class qNParEGO(MultiObjectiveAxInterface):
supports_single_objective = False

def __repr__(self):
smn = 'FixedNoiseGP'
smn = 'SingleTaskGP'
afn = 'qNParEGO'

return f'{smn}+{afn}'
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ testing = [
"certifi", # tries to prevent certificate problems on windows
"pytest",
"pre-commit", # system tests run pre-commit
"ax-platform >=0.3.5,<0.4.3"
"ax-platform >=0.3.5"
]
docs = [
"myst-nb>=0.17.1",
Expand All @@ -56,7 +56,7 @@ docs = [
]

ax = [
"ax-platform >=0.3.5,<0.4.3"
"ax-platform >=0.3.5"
]

[project.urls]
Expand Down
Loading