Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves: ImportError cannot import name FixedNoiseGP from botorch.models.gp_regression #179

Conversation

flo-schu
Copy link
Collaborator

@flo-schu flo-schu commented Nov 18, 2024

FixedNoiseGP was deprecated for a while. The PR replaces FixedNoiseGP with SingleTaskGP. If ax tests pass, this should be ready to merge. SingleTaskGP has already been used in #98

@flo-schu flo-schu changed the title Resolves: ImportError cannot import name fixednoisegp from botorchmodelsgp regression Resolves: ImportError cannot import name FixedNoiseGP from botorch.models.gp_regression Nov 18, 2024
@schmoelder schmoelder changed the base branch from master to dev November 18, 2024 08:39
Copy link
Contributor

@schmoelder schmoelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flo-schu for fixing this!

Before merging, you could also try if this runs with the latest version of ax which is currently pinned to <0.4.3 (see https://github.com/fau-advanced-separations/CADET-Process/blob/dev/pyproject.toml#L59) to avoid crashes.

Note, the CI currently does not run the optimization tests. So we have to run those locally. I know, not ideal but that's just how it is for now. 😅

@ronald-jaepel
Copy link
Collaborator

I've run the tests, all Ax-adapter tests work, only COBYLA breaks due to unrelated issues.
I've removed the version pin and would merge if nobody disagrees.

@schmoelder schmoelder merged commit 8384f14 into dev Nov 19, 2024
4 checks passed
@schmoelder schmoelder deleted the 174-importerror-cannot-import-name-fixednoisegp-from-botorchmodelsgp_regression branch November 19, 2024 15:07
@flo-schu
Copy link
Collaborator Author

Before merging, you could also try if this runs with the latest version of ax which is currently pinned to <0.4.3 (see https://github.com/fau-advanced-separations/CADET-Process/blob/dev/pyproject.toml#L59) to avoid crashes.

Sorry @schmoelder, I was swamped the last couple of days. Thanks @ronald-jaepel for running the tests ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'FixedNoiseGP' from 'botorch.models.gp_regression'
3 participants