Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indonesian translation #123

Merged
merged 7 commits into from
Sep 20, 2021
Merged

Add Indonesian translation #123

merged 7 commits into from
Sep 20, 2021

Conversation

MD-IS
Copy link
Contributor

@MD-IS MD-IS commented Sep 12, 2021

Description

	Naturalize
	fix spell and grammar
	not using "apl" abbrev
	100% translated
@falzonv
Copy link
Owner

falzonv commented Sep 14, 2021

Hello,

Thank you very much for the initiative and the work done!

Except for a small remark (I will create the related comment after this message), everything looks good :-)

Best regards.

@falzonv
Copy link
Owner

falzonv commented Sep 15, 2021

Great, thank you for the fix!

I am currently preparing the next release and a couple of new strings will be added.
Let's wait a bit before merging the PR, so we can update directly here and merge once at the end just before the release.

@falzonv
Copy link
Owner

falzonv commented Sep 20, 2021

Perfect, let's merge then!
For future updates, please check ticket #80 :-)

@falzonv falzonv merged commit 160d518 into falzonv:main Sep 20, 2021
@falzonv
Copy link
Owner

falzonv commented Sep 20, 2021

@MD-IS

I just noticed a possible misunderstanding on the 3 strings in "Sections titles" of this commit:
f8560ec#diff-57bd8fe85c500ed06ccdeef5916b0db01d78d19d3dedf4ba07c8f9fb7728cef9

--- <string name="appearance_settings_title_general">General appearance</string>
--- <string name="appearance_settings_title_applications">Appearance of apps</string>
+++ <string name="appearance_settings_title_general">General</string>
+++ <string name="appearance_settings_title_clock">Clock</string>
+++ <string name="appearance_settings_title_applications">Apps</string>

Two actions were done:

  • Simplify the existing titles (from "General appearance" to "General", and from "Appearance of apps" to "Apps") because the text "Appearance" is already displayed as the title of the window
  • Add a new "Clock" title

Could you confirm that this is correct also in your translation? (the commit dbd1e89 only adds the Clock title)

=> If not, no need to create a new PR, just write the correct strings here and I will copy-paste them in the file :-)

@MD-IS
Copy link
Contributor Author

MD-IS commented Sep 21, 2021

    <string name="appearance_settings_title_general">Umum</string>
    <string name="appearance_settings_title_clock">Jam</string>
    <string name="appearance_settings_title_applications">Aplikasi</string>

@falzonv
Copy link
Owner

falzonv commented Sep 22, 2021

Perfect, integrated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants