Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(user, util): address broken links #2252

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Jul 18, 2024

The broken link itself has been discovered by @e-io.
I haven't been able to find what inserts the _asyncio module in the index. But it isn't easy to find that index anyway, is it?
Edit: I've found the culprit for that _asyncio in the index. We had aliased functions directly from the stdlib, so I went on to soft-deprecate them for now. I'll create an issue to deprecate them (but there is probably no rush to do so.)

The broken link itself has been discovered by @e-io.

Co-authored-by: PM <[email protected]>
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97f06a9) to head (f9301ef).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6852      6852           
  Branches      1260      1260           
=========================================
  Hits          6852      6852           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 requested review from nZac and kgriffs July 18, 2024 10:01
@vytas7 vytas7 changed the title docs(user): update Hypercorn link docs: address broken links Jul 18, 2024
@vytas7 vytas7 changed the title docs: address broken links docs(user, util): address broken links Jul 18, 2024
CaselIT
CaselIT previously approved these changes Jul 18, 2024
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion

docs/api/util.rst Outdated Show resolved Hide resolved
@vytas7 vytas7 requested a review from CaselIT July 18, 2024 20:38
@vytas7 vytas7 merged commit 6ba54b4 into falconry:master Jul 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants