-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 broken links; commas, and other typos. #313
Conversation
Also I've checked now falcon.readthedocs.io for broken links. Overall it's quite good. Two broken links were found only. On the page https://falcon.readthedocs.io/en/stable/_modules/index.html :
On the page https://falcon.readthedocs.io/en/stable/user/tutorial-asgi.html :
I may remove them as well if needed. The check was performed with this wonderful tool: |
With a tool mentioned above I have carefully tidied up all the Falcon Wiki as well. However, most pages had just 2-5 links to fix. |
that tool seems very useful! tanks for linking it. I'll try looking at this and the other links asap (I'm very busy this week sadly) thank you for the effort! |
Thanks for the effort, I'll try to fix the links in the main repo. IIRC Hypercorn was moved from Gitlab to GitHub, hence the issue. Edit: I see you actually fixed the Documatt one 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot! 💯 I really like the attention to the details.
We are planning on rebuilding the website using some kind of generator like Sphinx, MkDocs, etc in order to reduce the maintenance burden, but we'll probably still keep a fair bit of content, so your work wouldn't be lost.
Edit: and I heard from @CaselIT that you attended our sprint on Sunday. Unfortunately I had to leave in the morning so I didn't meet you in person (but maybe I saw your face in the conference 🙂 ).
Edit2: Created a PR for Falcon itself: falconry/falcon#2252.
@@ -99,7 +93,7 @@ <h1 class="block-title display-1">Falcon</h1> | |||
<p> | |||
<a href="https://www.kontrolnaya-rabota.ru/s/" target="_blank"><img src="img/sponsors/rabota.jpg" height="30" alt="Examination RU" style="margin-right: 10px"></a> | |||
|
|||
<a href="https://www.pnk.sh/python-falcon" target="_blank"><img src="img/sponsors/paris.svg" height="30" alt="Paris Kejser" style="margin-right: 10px"></a> | |||
<a href="www.youtube.com/c/ParisNakitaKejser" target="_blank"><img src="img/sponsors/paris.svg" height="30" alt="Paris Kejser" style="margin-right: 10px"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we missed the scheme there. I'll fix it.
As for links in "Who's using Falcon?": Initially I was trying to find new links of these projects, but, then, I found that most of them don't exist anymore. Even if any project might exist with a new web address, there is no guarantee that it is still based on Falcon. Or it might be another project with identical name. Anyway, I hope that the remaining list "Who's using Falcon?" is still enough huge :) As for links in other pages, I was checking all of them quite carefully. |
Sprints @EuroPython 2024